-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMT API surface updates #1359
PMT API surface updates #1359
Conversation
I generally like this. |
The reason I avoided specifying (2) in this PR was to keep things simple, as we can always implement (2) in a backwards compatible way if we need to in the future. However, I am supportive of making this more flexible initially if you are. |
I think It feels like a blemish to me that we need to configure its properties from inside I can't find any really satisfying variant that maintains backwards compatibility, so it seems likely that you have thought through all these options already and have landed on the most reasonable one. |
@michaelkleber see this section of the explainer for a discussion of doing this configuration at IG join time. If the argument doesn't convince you, happy to continue the argument here. I want to mention that with the
I don't include these details in the PR, but it is a natural extension. |
Ahh yes, thank you for reminding me of that Alternative configuration options section of the doc. Good summary of the options and their relative merits. Yup, I like |
SHA: 890d1be Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR fixes #1356 by allowing for processing modeling signals in
reportWin
out of the critical bidding path. This is beneficial for latency in cases where generating the encrypted modeling signals vector may impact auction latency.Additionally, the new API unlocks the possibility to use PAA with sensitive (i.e. previously readable only within
generateBid
) data outside of the critical path.Finally, the API is simplified in that we don't overload the
modelingSignals
output ofgenerateBid
anymore. We alsoslightly backtrack on having the payload format be a raw Uint8 array, since we aren't quite ready to commit to that and we are investigating alternatives.
Feedback welcome!