[Spec] Add client side support of selected reporting id for B&A #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brusshamilton PTAL. Thanks! |
qingxinwu
commented
Dec 2, 2024
spec.bs
Outdated
| 1. [=list/For each=] |igSize| in (|ig|'s [=interest group/size groups=])[|ad|'s | ||
| [=interest group ad/size group=]]: | ||
| 1. If |igSize| equals |adSize|, return |ad|. | ||
| 1. If |igSize| equals |adSize|, set |maybeMatchingAd| to |ad|, and [=iteration/break=]. | ||
| 1. If |
There was a problem hiding this comment.
oh just noticed this. Let me see what I wanted to do, and update it now.
There was a problem hiding this comment.
I probably wanted to spec this k-anon check. But I'll leave it to your k-anon handling pull request, if it sounds good.
brusshamilton
approved these changes
Dec 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 2, 2024
SHA: 896b8c7 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of selected reporting id from B&A response.
K-anon check of it will be handled in a separate PR for B&A response k-anon handling.
Also fix a bug in finding matching ad to make it align with implementation.
Preview | Diff