Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move title to alternatives considered #28

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Move title to alternatives considered #28

merged 3 commits into from
Dec 17, 2020

Conversation

ayuishii
Copy link
Collaborator

This change removes the title option and moves the Bucket Title section into Alternatives Considered.
It also removes title from all the example code to avoid confusing readers.

Issue: #27

@ayuishii ayuishii requested a review from pwnall December 15, 2020 00:55
pwnall
pwnall approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@pwnall pwnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ comments addressed. Thank you!

explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
@ayuishii
Copy link
Collaborator Author

Thank you for the review!

@ayuishii ayuishii merged commit d0418e9 into gh-pages Dec 17, 2020
@ayuishii ayuishii deleted the rm-title branch December 17, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwnall pwnall pwnall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayuishii @pwnall