Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bucket Interface to use "in parallel" and resolve promise once #109

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Update Bucket Interface to use "in parallel" and resolve promise once #109

merged 7 commits into from
Oct 10, 2023

Conversation

ayuishii
Copy link
Collaborator

@ayuishii ayuishii commented Oct 2, 2023 •
edited by pr-preview bot
Loading

Preview | Diff

evanstade
evanstade requested changes Oct 3, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
evanstade
evanstade requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@evanstade evanstade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with 1 nit

index.bs Outdated

1. Otherwise, [=/resolve=] |p| with false.
1. [=Queue a storage task=] to [=/resolve=] |p| with |persisted|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I was wondering why we use [=/resolve=] (with slash) but [=reject=] (without slash). I think both work in this case, but we should choose one and be consistent.

https://speced.github.io/bikeshed/#autolink-inside

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updated for the bucket interface. I'll follow-up for the bucket manager

@ayuishii ayuishii merged commit 9936006 into main Oct 10, 2023
2 checks passed
@ayuishii ayuishii deleted the ayuishii-bucket-interface branch October 10, 2023 22:47
github-actions bot added a commit that referenced this pull request Oct 10, 2023
@ayuishii @github-actions
Update Bucket Interface to use "in parallel" and resolve promise once (…
5f066ce 
…#109)

SHA: 9936006
Reason: push, by ayuishii

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ayuishii ayuishii mentioned this pull request Oct 11, 2023
Open
github-actions bot added a commit to ayuishii/storage-buckets that referenced this pull request Oct 13, 2023
@ayuishii @github-actions
Update Bucket Interface to use "in parallel" and resolve promise once (…
3a48f27 
…WICG#109)

SHA: 9936006
Reason: push, by ayuishii

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanstade evanstade evanstade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayuishii @evanstade