Add new sections for priority overriding signal and onpriortychange #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
kenchris
reviewed
Sep 22, 2020
| Similar to how `AbortSignal` has an | ||
| [`onabort`](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/onabort) | ||
| event to listen for a change in abort state, `TaskSignal` supports an | ||
| `onprioritychange` event to listen for changes in priority. |
There was a problem hiding this comment.
should be prioritychange as I assume that TaskSignal is an EventTarget (it should be) you can call addEventListener('prioritychange') in addition to .onprioritychange = ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenchris: adding text per our discussion on the TAG review thread. Is this example/text reasonably clear?
@natechapin can you PTAL?