Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pr-preview.json file #222

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Add .pr-preview.json file #222

merged 1 commit into from
Apr 17, 2024

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow
Copy link
Contributor Author

lukewarlow commented Apr 17, 2024

I think you also have to configure https://github.com/apps/pr-preview

Edit: https://github.com/tobie/pr-preview?tab=readme-ov-file#install suggests that WICG always has that installed

@otherdaniel
Copy link
Collaborator

Thanks. Let's try it out!

@otherdaniel otherdaniel merged commit abac6ed into WICG:main Apr 17, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 17, 2024
SHA: abac6ed
Reason: push, by otherdaniel

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mozfreddyb
Copy link
Collaborator

Nice, and it already seems to work in existing PRs! Thank you @lukewarlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants