Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing private -> local fetches #96

Closed
letitz opened this issue Jan 11, 2023 · 6 comments
Closed

Consider allowing private -> local fetches #96

letitz opened this issue Jan 11, 2023 · 6 comments

Comments

@letitz
Copy link
Collaborator

letitz commented Jan 11, 2023

At least at first, because it's much easier to deploy without breaking the web: https://crbug.com/1234044.

See also #91 (comment) where this was first mentioned.

We can keep the local/private/public distinction, but simply define a private network request as public -> non-public only.

If we do so, we should open a new issue on the backlog to block these requests again. It would be good to do, if we have the time.

@mikewest
Copy link
Member

If we drop it from the intial pass, I'd like for it to move to a "security considerations" section noting the remaining risk, and suggesting that browsers may/should want to close that gap in the future.

@letitz
Copy link
Collaborator Author

letitz commented Jan 13, 2023

Good idea! Mentioning it in the spec means we can avoid having another issue laying around.

I was thinking of saying that private -> local being blocked could be up to the user agent, but if no user agent does that, it's maybe misleading?

@mikewest
Copy link
Member

I'd think of this more like Cookie's documentation of known flaws/gaps (e.g. https://httpwg.org/http-extensions/draft-ietf-httpbis-rfc6265bis.html#section-8). "Hey, this is a thing that we know about, but haven't addressed yet. User agents should feel free to come up with clever ways of addressing it."

@letitz
Copy link
Collaborator Author

letitz commented Jan 13, 2023

Fair enough!

@letitz
Copy link
Collaborator Author

letitz commented Mar 2, 2023

In the end, I'm not sure it makes sense to remove from the spec right now. In Chromium, local -> loopback (fka private -> local) fetches from non-secure contexts were exempted from deprecation due to rollout difficulties, but they are subject to preflights when sent from secure contexts. It seems better to just have a Chromium bug to track eventually implementing the spec than amending the spec to reflect Chromium's current limitation?

@annevk
Copy link

annevk commented Mar 2, 2023

I think adding a warning in the specification that points to this issue reminding people about potential deployment difficulties might be good, but overall that sounds reasonable.

@letitz letitz closed this as completed in 0baa967 Mar 2, 2023
iVanlIsh pushed a commit to iVanlIsh/private-network-access that referenced this issue Nov 2, 2023
iVanlIsh pushed a commit to iVanlIsh/private-network-access that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants