Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify traversal and overhaul ongoing navigation tracking #109

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Specify traversal and overhaul ongoing navigation tracking #109

merged 5 commits into from
Jul 27, 2021

Commits on Jul 23, 2021

  1. Specify traversal and overhaul ongoing navigation tracking 

    This commit introduces a much more robust framework for tracking ongoing navigations. This fixes #130, for example, by appropriately keeping the signal around so that we can signal abort when necessary. It also ensures every same-document navigation ends in either navigationsuccess or navigationerror, with a few unified spec paths.

With this framework in hand, we can specify goTo()/back()/forward().
    @domenic
    domenic committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    6ee58b9 View commit details
    Browse the repository at this point in the history

  2. This doesn't work

    @domenic
    domenic committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    70b2fe0 View commit details
    Browse the repository at this point in the history

  3. Revert "This doesn't work" 

    This reverts commit 70b2fe0.
    @domenic
    domenic committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2b5278f View commit details
    Browse the repository at this point in the history

  4. I think this works?

    @domenic
    domenic committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    a2e5bf3 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Returned promise is never null

    @domenic
    domenic committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    c194cdd View commit details
    Browse the repository at this point in the history