-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name #83
Comments
Yeah, app history is more of a "least bad" name. The predecessor proposal was called "navigator" and lived on "Session" seems like it might be the right spec-level concept to encompass "history and navigation", but it feels like the wrong web-dev-facing concept. When web devs talk about "sessions" it's mostly about user sessions, being logged in and out, etc., and not about history and navigation. Between "history" and "navigation" I think most of the complexity (for web developers) comes in with history, so that's why I went with I'm happy to leave this open in case we come up with something brilliant. But my instincts are to stick with the inertia behind the current name, despite it not being perfect. |
How about |
navigationHistory? navigationStack? |
|
in appHistory, I am not sure what value "app" provides :-) at least "navigation history" provides a bit more clarification |
Well, I suppose the "app" part is signifying to importance of same-origin history for this API - most of the new functionality has to do with enabling an "app" to inspect and modify its own history. So I'm not totally opposed to "app" being in the name. But I do agree that if I had to pick one word to represent all this, it would be "navigation". Navigation to me represents the action that the API enables, "history" represents the state left behind by that action. Not to throw another wrench, but other good words: "page", "view," "site". For instance, pageHistory (or pageNavigation), as opposed to appHistory, if no one likes the word app. |
In that case it would be |
Better - |
@jakearchibald, @annevk, @smaug---- and I discussed this today. @smaug---- especially was of the opinion that this API is largely about navigation, and less so history. We tentatively thought that maybe just the name await navigation.navigate(url);
const entries = navigation.entries();
const currentEntry = navigation.current; // or currentEntry? or now?
await navigation.transition.finished;
await navigation.back();
await navigation.goTo(key); This seems pretty OK to me. What do other folks think? |
I like it. Are there any chances of library/global conflicts? I tried doing some searching to see if anything puts |
It's always hard to say, but generally on the web platform we haven't had many such conflicts. (The only one I'm aware of is when TC39 tried to introduce |
Navigation is not a bad name, though it seem a lot more natural to call the-stateful-thing-you-call-navigate-on navigator, which — oh, wait, it seems that’s taken? perhaps this is not such a good name. :) Can’t say I would look forward much to mistyping and misreading this all the time, and I’m a native speaker, so it may be more troublesome for others. AppHistory seemed fine to me — FWIW, the moment I saw that name, I knew what it was gonna be about, though I couldn’t nec explain why? Of course this won’t make or break it but I do hope folks land on anything-but-navigation (because of navigator I mean — it seems fine conceptually). ( |
Unfortunately, I agree that "Navigation" may be too similar to the existing Navigator object (which ironically doesn't seem to have much to do with navigating). Perhaps "ApplicationState"? |
Maybe - window.navigator.app? |
I'd be happy with Aside from just being better in a number of ways, there are two restrictions
Based on that, there still isn't a name that jumps out at me, but here goes:
|
Spitballing in case one of these clicks with people or, more likely, serves as a prompt.
To be safe I’m not gonna make any claim about which of these are jokes and which I actually think are potentially good. If you hate them all, then they’re all jokes :) |
Placing this on the radar if it’s not already: the currently unqualified/unprefixed use of "navigate"/"nav" in global interface, operation, and event names in CSS Spatial Navigation proposal. |
Hey everyone, After a half-year with no particularly better ideas, and a bit more offline discussion with @annevk and @smaug----, we think The way in which the name starts with the same seven characters as This issue will remain open to track renaming everything (which will be fun 😬). |
This enum is too specific to the the navigation timing API and its idiosyncrasies to use the valuable name "NavigationType". In particular the API formerly known as app history (WICG/navigation-api#83) would like to use that name.
I'm working on a draft spec PR, but I want to get some any feedback on the details of the rename as early as possible. Noticeable developer-visible renames
Class name changesThese are mostly not developer-impacting in mainstream code scenarios, but can impact e.g. feature detection. So we can make them longer and uglier if we want. We should avoid changing them after shipping.
Not-exposed IDL name changesThese names, for dictionaries and enums, are not something developers have any interaction with, and the only concern is clarity and avoiding collisions within the spec ecosystem. We can change them at any time.
|
It seems a little strange to me that these don't have the word
Same here for these two, but maybe not as important because they're not dev-facing. |
Yeah, fair point, let me do some updates... |
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804}
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804}
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804}
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames various "AppHistoryEntry" data structures and fields to "NavigationApiHistoryEntry". This crosses the Blink/browser boundary. Bug: 1300246 Change-Id: I878affd6c1ca2660b5d574bab8582467c9b51293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523006 Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981872}
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames various fields of history entries, from "app history key", "app history id", "app history state", and "protect URL in app history" to their corresponding "navigation API" counterparts. This crosses the Blink/browser boundary. Bug: 1300246 Change-Id: Ifaf47859b49e971657c0e3c2217f1446b6a2bec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523469 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981910}
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL tidies up remaining references to app history across the codebase, mostly in comments and in enum names. Some DOMException messages also were forgotten in previous passes, and needed to be updated. Bug: 1300246 Change-Id: I10eeffb0cb6cc753679d45e450c8f5268bd500c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523471 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#982361}
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames the Blink RuntimeEnabledFeature from AppHistory to NavigationApi. While here, we remove the origin_trial_feature_name key since the origin trial is no longer relevant to tip-of-trunk code. Bug: 1300246 Change-Id: I66dd86dce6d8bef7fa38353009fe6cea0cdbcf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537549 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#982891}
….yml, a=testonly Automatic update from web-platform-tests Adjust URL of the navigation API in its META.yml This follows from change of spec name and title: WICG/navigation-api#83. Further test updates, including renaming the directory, will happen in subsequent commits. -- wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f wpt-pr: 33129
… (1/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (1/n) (#33132) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980648} Co-authored-by: Domenic Denicola <[email protected]> -- wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8 wpt-pr: 33132
… (2/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (2/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980702} -- wpt-commits: 4e628b145e52797f421c7f832d13014387aac961 wpt-pr: 33182
… (3/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (3/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804} -- wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232 wpt-pr: 33184
….yml, a=testonly Automatic update from web-platform-tests Adjust URL of the navigation API in its META.yml This follows from change of spec name and title: WICG/navigation-api#83. Further test updates, including renaming the directory, will happen in subsequent commits. -- wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f wpt-pr: 33129
… (1/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (1/n) (#33132) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980648} Co-authored-by: Domenic Denicola <[email protected]> -- wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8 wpt-pr: 33132
… (2/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (2/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980702} -- wpt-commits: 4e628b145e52797f421c7f832d13014387aac961 wpt-pr: 33182
… (3/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (3/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804} -- wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232 wpt-pr: 33184
….yml, a=testonly Automatic update from web-platform-tests Adjust URL of the navigation API in its META.yml This follows from change of spec name and title: WICG/navigation-api#83. Further test updates, including renaming the directory, will happen in subsequent commits. -- wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f wpt-pr: 33129
… (1/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (1/n) (#33132) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980648} Co-authored-by: Domenic Denicola <[email protected]> -- wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8 wpt-pr: 33132
… (2/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (2/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980702} -- wpt-commits: 4e628b145e52797f421c7f832d13014387aac961 wpt-pr: 33182
… (3/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (3/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804} -- wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232 wpt-pr: 33184
….yml, a=testonly Automatic update from web-platform-tests Adjust URL of the navigation API in its META.yml This follows from change of spec name and title: WICG/navigation-api#83. Further test updates, including renaming the directory, will happen in subsequent commits. -- wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f wpt-pr: 33129
… (1/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (1/n) (#33132) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980648} Co-authored-by: Domenic Denicola <[email protected]> -- wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8 wpt-pr: 33132
… (2/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (2/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980702} -- wpt-commits: 4e628b145e52797f421c7f832d13014387aac961 wpt-pr: 33182
… (3/n), a=testonly Automatic update from web-platform-tests App history API to navigation API rename (3/n) See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804} -- wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232 wpt-pr: 33184
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL implements the following renames: * window.appHistory → window.navigation * appHistory.current → navigation.currentEntry * appHistory.updateCurrent() → navigation.updateCurrentEntry() * appHistory currentchange event → navigation currententrychange event * appHistory.goTo() → navigation.traverseTo() Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing. No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either. Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class. Bug: 1300246 Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980648} NOKEYCHECK=True GitOrigin-RevId: 3ccf5749316b2bf4dc8105c176233ce5f1620cfd
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files. While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446. Bug: 1300246 Change-Id: Ieef0329e7a309c242b5391f050878bc182487905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#980702} NOKEYCHECK=True GitOrigin-RevId: 302ac08d24813e79df5d17fbbea00e51815112d0
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications. Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL. This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments. Bug: 1300246 Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981804} NOKEYCHECK=True GitOrigin-RevId: e65e212e00b19e814e56c697a7b67a5895916a10
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames various "AppHistoryEntry" data structures and fields to "NavigationApiHistoryEntry". This crosses the Blink/browser boundary. Bug: 1300246 Change-Id: I878affd6c1ca2660b5d574bab8582467c9b51293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523006 Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981872} NOKEYCHECK=True GitOrigin-RevId: cd30f5f8cd986ed1d95f12af2004b19f749eadb4
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames various fields of history entries, from "app history key", "app history id", "app history state", and "protect URL in app history" to their corresponding "navigation API" counterparts. This crosses the Blink/browser boundary. Bug: 1300246 Change-Id: Ifaf47859b49e971657c0e3c2217f1446b6a2bec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523469 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#981910} NOKEYCHECK=True GitOrigin-RevId: cc094fbd472dbee9952ae494907897bde03e695c
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL tidies up remaining references to app history across the codebase, mostly in comments and in enum names. Some DOMException messages also were forgotten in previous passes, and needed to be updated. Bug: 1300246 Change-Id: I10eeffb0cb6cc753679d45e450c8f5268bd500c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523471 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#982361} NOKEYCHECK=True GitOrigin-RevId: 3081074af94f0a75697fe86807e62ef7f1538b73
See WICG/navigation-api#83 and WICG/navigation-api#203 for context. This CL renames the Blink RuntimeEnabledFeature from AppHistory to NavigationApi. While here, we remove the origin_trial_feature_name key since the origin trial is no longer relevant to tip-of-trunk code. Bug: 1300246 Change-Id: I66dd86dce6d8bef7fa38353009fe6cea0cdbcf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537549 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#982891} NOKEYCHECK=True GitOrigin-RevId: 2e04818e615a118c8461ce53f3fc29dbf5526873
I'm somewhat hesitant to raise this bikeshed, but #82 (comment) made me think it. Should it be named
appHistory
?Perhaps
appSession
would reflect things a tiny bit better? (I guess the one potential confusing thing here is that it's not 1:1 withsessionStorage
, butappHistory
is not 1:1 withhistory
either.)The text was updated successfully, but these errors were encountered: