Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing navigationStartTimeStamp with navigationStart #8

Closed
esprehn opened this issue Feb 3, 2021 · 5 comments · Fixed by #27
Closed

Consider replacing navigationStartTimeStamp with navigationStart #8

esprehn opened this issue Feb 3, 2021 · 5 comments · Fixed by #27

Comments

@esprehn
Copy link

esprehn commented Feb 3, 2021

This would match the performance timing record naming. ex. https://developer.mozilla.org/en-US/docs/Web/API/Navigation_timing_API

@domenic
Copy link
Collaborator

domenic commented Feb 3, 2021

That makes sense. I thought the symmetry with the navigationEvent.timeStamp property would be nice, but I think in general I've been going for too-long names in this API; see also #1.

@esprehn
Copy link
Author

esprehn commented Feb 3, 2021

ah yeah that makes sense, +1 to the shorter names.

domenic added a commit that referenced this issue Feb 5, 2021
Closes #8 by renaming. Closes #12 by changing the semantics to when the navigation is initiated.

This might be refined further as we figure out navigation queuing.
domenic added a commit that referenced this issue Feb 5, 2021
Closes #8 by renaming. Closes #12 by changing the semantics to when the navigation is initiated.

This might be refined further as we figure out navigation queuing.
@tbondwilkinson
Copy link
Contributor

Mark as closed?

@domenic
Copy link
Collaborator

domenic commented Feb 11, 2021

#27 hasn't been merged yet, and has an outstanding question that I'm hoping to get some insight from experts on... I gotta poke them.

@domenic
Copy link
Collaborator

domenic commented Feb 11, 2021

Some discussion with @mmocny and @philipwalton revealed that navigationStart is basically deprecated. Also, its timeline is not the same as event.timeStamp. So, that's not a great name.

I'm going to go temporarily with startTime, but there's a larger question about making sure we align with other WebPerf proposals for tracking navigations. Maybe, in the end, we don't even do this via properties of the event object at all, but instead use the performance timeline API. Or maybe we have a PerformanceTimelineEntry as a property of the event. Tricky.

I'll open a new issue to track that larger evolution, and close this one with a renaming to startTime.

domenic added a commit that referenced this issue Feb 11, 2021
Closes #8 by renaming to something shorter, although not to the proposed name since navigationStart is apparently deprecated.

Closes #12 by changing the semantics to when the navigation is initiated to be more useful.

Points to #33 for further work on this area.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants