Beforeinstallprompt (attempt 2) #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Comment on lines
+156
to
+157
| if the document is not <a data-cite= | ||
| "appmanifest#dfn-is-installable">installable</a>. |
There was a problem hiding this comment.
Maybe
Suggested change
| if the document is not <a data-cite= | |
| "appmanifest#dfn-is-installable">installable</a>. | |
| if the document is not [=installed web application|installable=]. |
Note that "is installable" is gone from the other spec... maybe it should be resurrected here?
| @@ -17,7 +17,7 @@ | |||
| github: "WICG/manifest-incubations", | |||
| shortName: "manifest-incubations", | |||
| xref: { | |||
| specs: ["appmanifest"], | |||
| specs: ["appmanifest", "dom"], | |||
There was a problem hiding this comment.
Note, if you data-cite="DOM" below, you don't need it here. Up to you which way you use it.
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
…' into beforeinstallprompt
| </p> | ||
| <ol> | ||
| <li>Wait until the {{Document}} of the <a>top-level browsing | ||
| context</a> is <a data-cite="html#completely-loaded">completely |
There was a problem hiding this comment.
"Completely loaded" is not a exported term from HTML, which probably means it's not the right thing to link to?
Comment on lines
+196
to
+197
| <li>If there is already an <a data-lt= | ||
| "present an install prompt">install prompt being presented</a> or if |
There was a problem hiding this comment.
Suggested change
| <li>If there is already an <a data-lt= | |
| "present an install prompt">install prompt being presented</a> or if | |
| <li>If there is already an <a>install prompt being presented</a> or if |
There was a problem hiding this comment.
This is linked from a couple sections - how should I resolve links to "present an install prompt"?
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for closing the old issue, I can't figure out how to hook this back up to that one. Restarting, and now without a mountain of commits.
Previous feedback is here:
#9
Preview | Diff