This repository has been archived by the owner on Mar 19, 2018. It is now read-only.
Change the PaymentRequestUpdateEvent model to better match FetchEvent #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a bug in the event model where if a page didn't listen for the update event and call updatePaymentRequest then the user interface would be permanently disabled. This change modifies the model to mirror the way that the FetchEvent works in a ServiceWorker. If a page wishes to carry out an update then it calls updateWith and provides a promise that will settle when the page is ready to proceed. If it is resolved with a PaymentDetails dictionary then the payment request will be updated with the supplied information. If it is rejected then no update occurs and the request can continue. If the page does not listen for the event or does not call updateWith then the request can continue.
| this value to the <code>items</code> field of <em>target</em>@[[\details]]. | ||
| </li> | ||
| <li> | ||
| If <code>details</code>contains a <code>shippingOptions</code> value, then |
|
Looks great! |
|
@jakearchibald, thanks for the review. |
|
Merged as b163172 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a bug in the event model where if a page didn't listen for the update event and call updatePaymentRequest then the user interface would be permanently disabled. This change modifies the model to mirror the way that the FetchEvent works in a ServiceWorker. If a page wishes to carry out an update then it calls updateWith and provides a promise that will settle when the page is ready to proceed. If it is resolved with a PaymentDetails dictionary then the payment request will be updated with the supplied information. If it is rejected then no update occurs and the request can continue. If the page does not listen for the event or does not call updateWith then the request can continue.
You can read this change in place in the spec here.