Meta keys should not match. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 once we figure out what's up with the tests. |
This was referenced Apr 24, 2019
|
@cdata I'd like to land this before releasing v5 since it's also a breaking change. I'll add it to my calendar to get this sorted tomorrow. |
|
Is there any timeline on when v5 will be released? Would like to upgrade to this whenever that drops, so that I don't need to stay pinned to |
|
I can try to roll it out tomorrow
…On Wed, Jun 12, 2019, 3:12 AM Karl Horky ***@***.***> wrote:
Is there any timeline on when v5 will be released?
Would like to upgrade to this whenever that drops, so that I don't need to stay
pinned to 4.0.1
<#118 (comment)>.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#184?email_source=notifications&email_token=AAIEKDNHRROELDG675NT53TP2DDXBA5CNFSM4FWVJJOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXP5QIA#issuecomment-501209120>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIEKDJAV2MBIQH4GJVLELTP2DDXBANCNFSM4FWVJJOA>
.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses heuristic update in #167.
@alice PTAL when you have a chance 😸