Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on event reporting #78

Merged
merged 7 commits into from
May 5, 2023
Merged

Elaborate on event reporting #78

merged 7 commits into from
May 5, 2023

Conversation

gtanzer
Copy link
Collaborator

@gtanzer gtanzer commented Apr 19, 2023

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
@domfarolino
Copy link
Collaborator

Also just so I'm clear, it's https://pr-preview.s3.amazonaws.com/WICG/fenced-frame/pull/78.html#finalize-a-reporting-destination that will report an event that is finalized right after report an event early-returns when it encounters pending events, is that right? So if report an event is invoked when the reporting map's keys are lists we do nothing, and expect finalize a reporting destination to do the actual sending sometime later?

@gtanzer
Copy link
Collaborator Author

gtanzer commented May 4, 2023

Also just so I'm clear, it's https://pr-preview.s3.amazonaws.com/WICG/fenced-frame/pull/78.html#finalize-a-reporting-destination that will report an event that is finalized right after report an event early-returns when it encounters pending events, is that right? So if report an event is invoked when the reporting map's keys are lists we do nothing, and expect finalize a reporting destination to do the actual sending sometime later?

Yes, that's right. That's also how the implementation works (see callsites of FencedFrameReporter::OnUrlMappingReady https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:content/browser/fenced_frame/fenced_frame_reporter.cc;drc=e0e0d24aaa54727dc0a8bc4b159ccdf80d3f5d8d;bpv=1;bpt=1;l=243)

@domfarolino domfarolino merged commit 5af7b1a into master May 5, 2023
@domfarolino domfarolino deleted the report-event branch May 5, 2023 17:14
github-actions bot added a commit that referenced this pull request May 5, 2023
SHA: 5af7b1a
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants