Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatic beacons to require opt-in before sending #129

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

blu25
Copy link
Collaborator

@blu25 blu25 commented Oct 13, 2023

This is a follow up to this previous PR that makes the following changes:

  • Ad frames must opt in using setReportEvent...() before an automatic beacon is sent out.
  • The once parameter will only allow the next automatic beacon to be sent, versus the previous change's behavior of just stopping data from being sent after the next beacon.
  • Automatic beacons, when sent out, will still send out to all registered destinations.

Preview | Diff

@domfarolino domfarolino merged commit 94b48b1 into master Oct 23, 2023
2 checks passed
@domfarolino domfarolino deleted the liam-automatic-beacon-opt-in branch October 23, 2023 15:51
github-actions bot added a commit that referenced this pull request Oct 23, 2023
SHA: 94b48b1
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants