Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #59 - Add a UA-Bitness hint #60

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fixes #59 - Add a UA-Bitness hint #60

merged 2 commits into from
Mar 15, 2021

Conversation

miketaylr
Copy link
Collaborator

This is the infra half to WICG/ua-client-hints#210

(And apparently we forgot to add UA-Platform-Version 🙈 )

@miketaylr miketaylr requested a review from yoavweiss March 13, 2021 00:24
@miketaylr
Copy link
Collaborator Author

PTAL, @yoavweiss

yoavweiss
yoavweiss approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the other half lands :)

@miketaylr
Copy link
Collaborator Author

Thanks!

@miketaylr miketaylr merged commit f9b2ac2 into WICG:main Mar 15, 2021
@miketaylr miketaylr deleted the issues/59/1 branch March 15, 2021 22:26
@bat999
Copy link

bat999 commented Mar 23, 2021

Hi
Anybody here from Google?
Please add a bitness test to this demo ---> https://user-agent-client-hints.glitch.me/

@miketaylr
Copy link
Collaborator Author

Hi @bat999. Thanks, good reminder. Once we're certain we want to implement it as specced, we can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketaylr @bat999 @yoavweiss