Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jason seagoing client- gallery mode involves all available images #11

Open
smccue2019 opened this issue Feb 4, 2021 · 3 comments
Open

Comments

@smccue2019
Copy link

Passed to me by Ryan so I may be describing too broadly. A symptom is that gallery mode is unusable when the client is ashore and talking to the seagoing server is on ship.

@rgov rgov transferred this issue from WHOIGit/ndsf-sealog-server Feb 5, 2021
@rgov
Copy link
Member

rgov commented Feb 5, 2021

I investigated this a little more. The actual behavior is that when we load the first page of the gallery, it loads 16 images per page (configurable with the UI popup), but it loads them for all 3 cameras, even though we may initially only be looking at, say, SubSea1. So it downloads 16x3 images when we only need 16.

When we advance to the next page, it only loads them for the currently selected camera.

@webbpinner
Copy link
Contributor

webbpinner commented Feb 18, 2021

Try updating this line in ./src/components/lowering_gallery.js:
<Tabs className="category-tab" variant="pills" id="galleries">
with:
<Tabs className="category-tab" variant="pills" id="galleries" mountOnEnter={true} unmountOnExit={true}>

per react-bootstrap docs: https://react-bootstrap.github.io/components/tabs/#tabs-api

@mcschwartzman
Copy link
Contributor

mcschwartzman commented Jan 4, 2023

Tina says "the images might be getting downloaded on each gallery reload rather than being cached" Scotty says this might not be happening anymore

rgov pushed a commit that referenced this issue Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants