Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing position #418

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jonatanmindroad
Copy link
Contributor

When an instrument records the position as e.g. "N/A" i should be treated the same as None. The easiest way to do this is to except both TypeError and ValueError.

When an instrument records the position as e.g. "N/A" i should be treated the same as None. The easiest way to do this is to except both TypeError and ValueError.
@joefutrelle
Copy link
Contributor

LGTM, can you show me some example output from an instrument? I was not aware that instruments were using "N/A" for latitude and longitude attributes. Do we know what else might be recorded in these fields? I want to, for instance, avoid recording fill values.

@joefutrelle joefutrelle self-assigned this Oct 25, 2024
@joefutrelle joefutrelle added this to the v4.3 milestone Oct 25, 2024
@jonatanmindroad
Copy link
Contributor Author

Coming into this as a programmer and not a domain expert. I'm not sure if the ship specifically reports N/A or if it is added downstream because no position signal was received.

Here is a gist with an example hdr file with missing values:
https://gist.github.com/jonatanmindroad/31bdbc4992b77449e1c0b0371e3f0692

@joefutrelle
Copy link
Contributor

Thanks. Regardless of how the N/A gets there, it does, and obviously needs to be handled. This looks like a general way to handle whatever the acquisition software (which is closed source) is producing.

@joefutrelle joefutrelle merged commit b3210cd into WHOIGit:master Oct 29, 2024
@jonatanmindroad jonatanmindroad deleted the handle_missing_position branch October 29, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants