Skip to content
Ruby on Rails CI

add back sony_cid, make admin_data more object like in pbcore_xml_entry #437

Sign in to view logs

add back sony_cid, make admin_data more object like in pbcore_xml_entry

add back sony_cid, make admin_data more object like in pbcore_xml_entry #437

GitHub Actions / JUnit Test Report failed Dec 19, 2023 in 0s

281 tests run, 232 passed, 41 skipped, 8 failed.

Annotations

Check failure on line 88 in spec/models/bulkrax/pbcore_xml_entry_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/models/bulkrax/pbcore_xml_entry_spec.rb.Bulkrax::PbcoreXmlEntry#build with raw_metadata succeeds 

expected: "Complete"
     got: "Failed"

(compared using ==)
Raw output 
Failure/Error: expect(xml_entry.status).to eq('Complete')

  expected: "Complete"
       got: "Failed"

  (compared using ==)
./spec/models/bulkrax/pbcore_xml_entry_spec.rb:88:in `block (4 levels) in <module:Bulkrax>'

Check failure on line 93 in spec/models/bulkrax/pbcore_xml_entry_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/models/bulkrax/pbcore_xml_entry_spec.rb.Bulkrax::PbcoreXmlEntry#build with raw_metadata builds entry 

expected: {"admin_set_id"=>"MyString", "bulkrax_identifier"=>"cpb-aacip-20-000000hr", "children"=>[], "delete"=>nil, "file"=>nil, "model"=>nil, "rights_statement"=>[nil], "visibility"=>"open"}
     got: {"bulkrax_identifier"=>"cpb-aacip-20-000000hr", "model"=>nil}

(compared using ==)

Diff:


@@ -1,9 +1,3 @@
-"admin_set_id" => "MyString",
 "bulkrax_identifier" => "cpb-aacip-20-000000hr",
-"children" => [],
-"delete" => nil,
-"file" => nil,
 "model" => nil,
-"rights_statement" => [nil],
-"visibility" => "open",
Raw output 
Failure/Error:
  expect(xml_entry.parsed_metadata).to eq(
    {
      "admin_set_id"=>"MyString",
      "bulkrax_identifier"=>"cpb-aacip-20-000000hr",
      "children"=>[],
      "delete"=>nil,
      "file"=>nil,
      "model"=>nil,
      "rights_statement"=>[nil],
      "visibility"=>"open"

  expected: {"admin_set_id"=>"MyString", "bulkrax_identifier"=>"cpb-aacip-20-000000hr", "children"=>[], "delete"=>nil, "file"=>nil, "model"=>nil, "rights_statement"=>[nil], "visibility"=>"open"}
       got: {"bulkrax_identifier"=>"cpb-aacip-20-000000hr", "model"=>nil}

  (compared using ==)

  Diff:


  @@ -1,9 +1,3 @@
  -"admin_set_id" => "MyString",
   "bulkrax_identifier" => "cpb-aacip-20-000000hr",
  -"children" => [],
  -"delete" => nil,
  -"file" => nil,
   "model" => nil,
  -"rights_statement" => [nil],
  -"visibility" => "open",
./spec/models/bulkrax/pbcore_xml_entry_spec.rb:93:in `block (4 levels) in <module:Bulkrax>'

Check failure on line 170 in spec/models/bulkrax/pbcore_xml_entry_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/models/bulkrax/pbcore_xml_entry_spec.rb.Bulkrax::PbcoreXmlEntry#build with raw_metadata with asset raw_metadata builds entry 

expected: {"admin_data_gid"=>"gid://ams/admindata/1", "admin_set_id"=>"MyString", "asset_types"=>[], "audience_...."], "series_title"=>["Houston Symphony"], "subject"=>[], "topics"=>["Music"], "visibility"=>"open"}
     got: {"admin_data_gid"=>"gid://ams/admindata/1", "admin_set_id"=>"MyString", "asset_types"=>[], "audience_...."], "series_title"=>["Houston Symphony"], "subject"=>[], "topics"=>["Music"], "visibility"=>"open"}

(compared using ==)

Diff:
@@ -7,6 +7,7 @@
 "bulkrax_identifier" => "1-Asset-0-1",
 "bulkrax_importer_id" => 1,
 "clip_description" => [],
+"contributors" => [],
 "copyright_date" => [],
 "created_date" => ["1996-05-11"],
 "date" => [],
Raw output 
Failure/Error:
  expect(xml_entry.parsed_metadata).to eq(
    {
      "bulkrax_identifier"=>"1-Asset-0-1",
      "bulkrax_importer_id"=>1,
      "model"=>"AssetResource",
      "id"=>"cpb-aacip-20-000000hr",
      "series_title"=>["Houston Symphony"],
      "description"=>["5/11/96"],
      "episode_description"=>[],
      "series_description"=>

  expected: {"admin_data_gid"=>"gid://ams/admindata/1", "admin_set_id"=>"MyString", "asset_types"=>[], "audience_...."], "series_title"=>["Houston Symphony"], "subject"=>[], "topics"=>["Music"], "visibility"=>"open"}
       got: {"admin_data_gid"=>"gid://ams/admindata/1", "admin_set_id"=>"MyString", "asset_types"=>[], "audience_...."], "series_title"=>["Houston Symphony"], "subject"=>[], "topics"=>["Music"], "visibility"=>"open"}

  (compared using ==)

  Diff:
  @@ -7,6 +7,7 @@
   "bulkrax_identifier" => "1-Asset-0-1",
   "bulkrax_importer_id" => 1,
   "clip_description" => [],
  +"contributors" => [],
   "copyright_date" => [],
   "created_date" => ["1996-05-11"],
   "date" => [],
./spec/models/bulkrax/pbcore_xml_entry_spec.rb:170:in `block (5 levels) in <module:Bulkrax>'

Check failure on line 168 in spec/controllers/catalog_controller_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/controllers/catalog_controller_spec.rb.CatalogController GET export when number of records is < browswer limit when the export type is CSV when the "object_type" param is "digital_instantiation" sends the CSV file as a download with a clear filename and correct Content-Type 

expected `#<Set: {}>.empty?` to return false, got true
Raw output 
Failure/Error: expect(actual_csv_rows).not_to be_empty
  expected `#<Set: {}>.empty?` to return false, got true
./spec/controllers/catalog_controller_spec.rb:168:in `block (6 levels) in <top (required)>'

Check failure on line 140 in spec/controllers/catalog_controller_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/controllers/catalog_controller_spec.rb.CatalogController GET export when number of records is < browswer limit when the export type is CSV when the "object_type" param is "physical_instantiation" sends the CSV file as a download with a clear filename and correct Content-Type 

expected `#<Set: {}>.empty?` to return false, got true
Raw output 
Failure/Error: expect(actual_csv_rows).not_to be_empty
  expected `#<Set: {}>.empty?` to return false, got true
./spec/controllers/catalog_controller_spec.rb:140:in `block (6 levels) in <top (required)>'

Check failure on line 12 in spec/indexers/contribution_resource_indexer_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/indexers/contribution_resource_indexer_spec.rb.ContributionResourceIndexer behaves like a Hyrax::Resource indexer #to_solr indexes base resource fields 

expected {"admin_set_id_ssim" => [""], "admin_set_sim" => nil, "admin_set_tesim" => nil, "affiliation_tesim" => nil, "...849a.png", "title_sim" => [], "title_tesim" => [], "valkyrie_bsi" => true, "visibility_ssi" => "restricted"} to include {:has_model_ssim => "ContributionResource"}
Diff:
@@ -1,4 +1,52 @@
-:alternate_ids_sim => (a collection containing exactly "id1" and "id2"),
-:has_model_ssim => "ContributionResource",
-:human_readable_type_tesim => "Contribution resource",
+"admin_set_id_ssim" => [""],
+"admin_set_sim" => nil,
+"admin_set_tesim" => nil,
+"affiliation_tesim" => nil,
+"alternate_ids_sim" => ["id1", "id2"],
+"based_near_label_tesim" => [],
+"based_near_sim" => [],
+"based_near_tesim" => [],
+"bulkrax_identifier_sim" => nil,
+"bulkrax_identifier_tesim" => nil,
+"contributor_role_tesim" => nil,
+"contributor_tesim" => [],
+"creator_tesim" => [],
+"date_created_tesim" => [],
+"date_modified_dtsi" => nil,
+"date_uploaded_dtsi" => nil,
+"depositor_ssim" => [nil],
+"depositor_tesim" => [nil],
+"description_tesim" => [],
+"edit_access_group_ssim" => [],
+"edit_access_person_ssim" => [],
+"embargo_history_ssim" => nil,
+"generic_type_si" => "Work",
+"hasRelatedImage_ssim" => [""],
+"hasRelatedMediaFragment_ssim" => [""],
+"has_model_ssim" => "Contribution",
+"human_readable_type_tesim" => "Contribution resource",
+"id" => "",
+"isPartOf_ssim" => [""],
+"keyword_sim" => [],
+"keyword_tesim" => [],
+"lease_history_ssim" => nil,
+"member_ids_ssim" => [],
+"member_of_collection_ids_ssim" => [],
+"portrayal_tesim" => nil,
+"read_access_group_ssim" => [],
+"read_access_person_ssim" => [],
+"related_url_tesim" => [],
+"resource_type_sim" => [],
+"resource_type_tesim" => [],
+"rights_statement_tesim" => [],
+"subject_sim" => [],
+"subject_tesim" => [],
+"suppressed_bsi" => false,
+"system_create_dtsi" => nil,
+"system_modified_dtsi" => nil,
+"thumbnail_path_ss" => "/assets/default-f936e9c3ea7a38e2c2092099586a71380b11258697b37fb4df376704495a849a.png",
+"title_sim" => [],
+"title_tesim" => [],
+"valkyrie_bsi" => true,
+"visibility_ssi" => "restricted",
Raw output 
Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

  expected {"admin_set_id_ssim" => [""], "admin_set_sim" => nil, "admin_set_tesim" => nil, "affiliation_tesim" => nil, "...849a.png", "title_sim" => [], "title_tesim" => [], "valkyrie_bsi" => true, "visibility_ssi" => "restricted"} to include {:has_model_ssim => "ContributionResource"}
  Diff:
  @@ -1,4 +1,52 @@
  -:alternate_ids_sim => (a collection containing exactly "id1" and "id2"),
  -:has_model_ssim => "ContributionResource",
  -:human_readable_type_tesim => "Contribution resource",
  +"admin_set_id_ssim" => [""],
  +"admin_set_sim" => nil,
  +"admin_set_tesim" => nil,
  +"affiliation_tesim" => nil,
  +"alternate_ids_sim" => ["id1", "id2"],
  +"based_near_label_tesim" => [],
  +"based_near_sim" => [],
  +"based_near_tesim" => [],
  +"bulkrax_identifier_sim" => nil,
  +"bulkrax_identifier_tesim" => nil,
  +"contributor_role_tesim" => nil,
  +"contributor_tesim" => [],
  +"creator_tesim" => [],
  +"date_created_tesim" => [],
  +"date_modified_dtsi" => nil,
  +"date_uploaded_dtsi" => nil,
  +"depositor_ssim" => [nil],
  +"depositor_tesim" => [nil],
  +"description_tesim" => [],
  +"edit_access_group_ssim" => [],
  +"edit_access_person_ssim" => [],
  +"embargo_history_ssim" => nil,
  +"generic_type_si" => "Work",
  +"hasRelatedImage_ssim" => [""],
  +"hasRelatedMediaFragment_ssim" => [""],
  +"has_model_ssim" => "Contribution",
  +"human_readable_type_tesim" => "Contribution resource",
  +"id" => "",
  +"isPartOf_ssim" => [""],
  +"keyword_sim" => [],
  +"keyword_tesim" => [],
  +"lease_history_ssim" => nil,
  +"member_ids_ssim" => [],
  +"member_of_collection_ids_ssim" => [],
  +"portrayal_tesim" => nil,
  +"read_access_group_ssim" => [],
  +"read_access_person_ssim" => [],
  +"related_url_tesim" => [],
  +"resource_type_sim" => [],
  +"resource_type_tesim" => [],
  +"rights_statement_tesim" => [],
  +"subject_sim" => [],
  +"subject_tesim" => [],
  +"suppressed_bsi" => false,
  +"system_create_dtsi" => nil,
  +"system_modified_dtsi" => nil,
  +"thumbnail_path_ss" => "/assets/default-f936e9c3ea7a38e2c2092099586a71380b11258697b37fb4df376704495a849a.png",
  +"title_sim" => [],
  +"title_tesim" => [],
  +"valkyrie_bsi" => true,
  +"visibility_ssi" => "restricted",
Shared Example Group: "a Hyrax::Resource indexer" called from ./spec/indexers/contribution_resource_indexer_spec.rb:12
/usr/local/bundle/bundler/gems/hyrax-b7891b758411/lib/hyrax/specs/shared_specs/indexers.rb:20:in `block (3 levels) in <top (required)>'

Check failure on line 6 in spec/features/admin/admin_sets/add_multiple_userrole_as_viewer_and_manager_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/features/admin/admin_sets/add_multiple_userrole_as_viewer_and_manager_spec.rb.Add "manage" permissions to test role Assigning Permissions to AdminSets 

undefined method `save!' for #<Hyrax::AdministrativeSet id=nil internal_resource="AdminSet" created_at=nil updated_at=nil new_record=true alternate_ids=[] embargo_id=nil lease_id=nil title=["My Admin Set"] date_modified=nil date_uploaded=nil depositor=nil alternative_title=[] creator=["[email protected]"] description=nil>
Raw output 
Failure/Error: let!(:admin_set) { create(:hyrax_admin_set, with_permission_template: true ) }

NoMethodError:
  undefined method `save!' for #<Hyrax::AdministrativeSet id=nil internal_resource="AdminSet" created_at=nil updated_at=nil new_record=true alternate_ids=[] embargo_id=nil lease_id=nil title=["My Admin Set"] date_modified=nil date_uploaded=nil depositor=nil alternative_title=[] creator=["[email protected]"] description=nil>
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/configuration.rb:18:in `block in initialize'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/evaluation.rb:18:in `create'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/strategy/create.rb:12:in `block in result'
<internal:kernel>:90:in `tap'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/strategy/create.rb:9:in `result'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/factory.rb:43:in `run'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/factory_runner.rb:29:in `block in run'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/factory_runner.rb:28:in `run'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/strategy_syntax_method_registrar.rb:20:in `block in define_singular_strategy_method'
./spec/features/admin/admin_sets/add_multiple_userrole_as_viewer_and_manager_spec.rb:6:in `block (2 levels) in <top (required)>'

Check failure on line 8 in spec/features/admin/admin_sets/add_multiple_userrole_as_manager_spec.rb

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

./spec/features/admin/admin_sets/add_multiple_userrole_as_manager_spec.rb.AssignMultipleRolesAsManager. Add Manager permissions to user (Role) Assign set of user (role) as Manager to multiple AdminSet 

undefined method `save!' for #<Hyrax::AdministrativeSet id=nil internal_resource="AdminSet" created_at=nil updated_at=nil new_record=true alternate_ids=[] embargo_id=nil lease_id=nil title=["My Admin Set"] date_modified=nil date_uploaded=nil depositor=nil alternative_title=[] creator=["[email protected]"] description=nil>
Raw output 
Failure/Error: let!(:admin_set_1) { create :hyrax_admin_set }

NoMethodError:
  undefined method `save!' for #<Hyrax::AdministrativeSet id=nil internal_resource="AdminSet" created_at=nil updated_at=nil new_record=true alternate_ids=[] embargo_id=nil lease_id=nil title=["My Admin Set"] date_modified=nil date_uploaded=nil depositor=nil alternative_title=[] creator=["[email protected]"] description=nil>
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/configuration.rb:18:in `block in initialize'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/evaluation.rb:18:in `create'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/strategy/create.rb:12:in `block in result'
<internal:kernel>:90:in `tap'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/strategy/create.rb:9:in `result'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/factory.rb:43:in `run'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/factory_runner.rb:29:in `block in run'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/factory_runner.rb:28:in `run'
/usr/local/bundle/gems/factory_bot-4.11.1/lib/factory_bot/strategy_syntax_method_registrar.rb:20:in `block in define_singular_strategy_method'
./spec/features/admin/admin_sets/add_multiple_userrole_as_manager_spec.rb:8:in `block (3 levels) in <top (required)>'
View more details on GitHub Actions