Fix deprecation warnings due to upgrade #774
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gem to record deprecations. run: DEPENDENCIES_NEXT=1 DEPRECATION_BEHAVIOR="record" bundle exec rspec ref: scientist-softserv#61
This commit puts the 5.1 conditional around the DeprecationToolkit configurations.
This commit will address a warning where `digital_instantiation_attributes[:main_title]` is `nil` and that will always be true. Instead, we set the `main_title` value in the `digital_instantiation_attributes` so it checks for a string instead.
This commit will change `@push.errors.values` to `@push.errors.map(&:values)` because `ActiveModel::Errors#values` is being deprecated in Rails 7.0.
This commit addresses the following warning: ``` DEPRECATION WARNING: Initializing a Blacklight::Configuration::ViewConfig implicitly (by calling gallery) is deprecated. Call it as gallery! or pass initialize arguments. (called from block in <class:CatalogController> at /app/samvera/hyrax-webapp/app/controllers/catalog_controller.rb:18) DEPRECATION WARNING: Initializing a Blacklight::Configuration::ViewConfig implicitly (by calling masonry) is deprecated. Call it as masonry! or pass initialize arguments. (called from block in <class:CatalogController> at /app/samvera/hyrax-webapp/app/controllers/catalog_controller.rb:19) DEPRECATION WARNING: Initializing a Blacklight::Configuration::ViewConfig implicitly (by calling slideshow) is deprecated. Call it as slideshow! or pass initialize arguments. (called from block in <class:CatalogController> at /app/samvera/hyrax-webapp/app/controllers/catalog_controller.rb:20) ```
This commit will fix the following deprecation: ``` DEPRECATION WARNING: render_hash_as_hidden_fields is deprecated and will be removed from a future release (Use Blacklight::HiddenSearchStateComponent instead). ```
This commit will move the `#search_fields` and `#thumbnail_url` methods from the Blacklight to the `ApplicationHelper` to avoid the deprecation warning. If we ever upgrade to Blacklight 8, the way the facets and the date range filter might have to be changed. It is already a lot different in Blacklight 7 but it still seems to work at least.
ShanaLMoore
reviewed
Aug 21, 2023
config/application.rb
Outdated
| unless App.rails_5_1? | ||
| DeprecationToolkit::Configuration.config do |config| | ||
| config.test_runner = :rspec | ||
| config.warnings_treated_as_deprecation = [//] |
There was a problem hiding this comment.
remove this line so that it excludes deprecation warnings from gems
We don't want to see deprecation warnings from gems.
|
Marking WIP pr as draft for now. We will revisit it in scientist-softserv#61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gem to record deprecations.
run via DEPENDENCIES_NEXT=1 DEPRECATION_BEHAVIOR="record" bundle exec rspec
ref: scientist-softserv#61