Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove actor customizations #758

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Remove actor customizations #758

merged 1 commit into from
Aug 15, 2023

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Aug 15, 2023

Refs scientist-softserv#30
Actor changes dealing with nested indexing are obsolete with upgrade.
Ran specs locally for DEPENDENCIES_NEXT=1 with only the 10 known failures appearing.

Conditionally remove env.curation_concern.reindex_extent

  • Custom actors use env.curation_concern.reindex_extent = "queue#{env.importing.id}" if env.importing in queued_nesting_indexer.rb and nested indexing is obsolete.
  • Both of the overridden actors are there to bring in the importer flag in order to support the nested indexing. There is no harm in keeping but they can be deleted during the cleanup of App.rails_5_1?
  • Jobs, Actors, and Indexers are all affected.
  • Unsure if any searches will break due to removing nested indexing... if so, after testing, may need to change to graph searches.

Refs scientist-softserv#30
Actor changes dealing with nested indexing are obsolete with upgrade.
@laritakr laritakr marked this pull request as draft August 15, 2023 20:40
@laritakr laritakr marked this pull request as ready for review August 15, 2023 21:10
@ShanaLMoore ShanaLMoore merged commit 79881a3 into develop Aug 15, 2023
6 checks passed
@kirkkwang kirkkwang deleted the i30-actor-overrides branch August 16, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants