⚙️ [i32] - resolve selenium error #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desired_capabilities is deprecated. This commit changes the way we initialize selenium driver per the newer requirements when dual booting. At this point, it resolves the error how there are still local timeout issues. ref: - https://github.com/SeleniumHQ/selenium/blob/trunk/rb/lib/selenium/webdriver/remote/driver.rb#L32 Issue: - scientist-softserv#64
ShanaLMoore
changed the title
This change allowed feature specs to run locally. I am not sure why this fixed things or why we are even able to connect to hyku.test so this may be a smell and something to dive into later. For now it unblocks devs though!
ShanaLMoore
changed the title
ShanaLMoore
commented
Aug 11, 2023
| @@ -235,4 +235,4 @@ services: | |||
| environment: | |||
| - JAVA_OPTS=-Dwebdriver.chrome.whitelistedIps= | |||
| - VIRTUAL_PORT=7900 | |||
| - VIRTUAL_HOST=chrome.ams.test | |||
| - VIRTUAL_HOST=chrome.hyku.test | |||
There was a problem hiding this comment.
NOTE: I don't understand why this change fixes it. And I also don't understand why we can connect to hyku.test when it's not defined in our docker setup. 🤔
No other docker projects are running so this must be coming from gbh's setup somehow. I think it's ok to proceed for now since it unblocks us however Rob/devops should prob look into it.
kirkkwang
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desired_capabilities is deprecated. This PR changes the way we initialize selenium driver per the newer requirements when dual booting.
It also changes the docker-compose.yml file to allow devs to run feature specs locally.
ref:
Issue:
I confirmed that feature specs can run locally in rails 5 and 6. There are still failures in rails 6 but we'll handle that in a separate ticket.
rails_5_1?
rails 6