Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into main to push some new features #669

Open
wants to merge 864 commits into
base: main
Choose a base branch
from

Merge pull request #926 from WGBH-MLA/dont-rush-redis-healthchecks

9fbe8e8
Select commit
Loading
Failed to load commit list.
Open

Merge develop into main to push some new features #669

Merge pull request #926 from WGBH-MLA/dont-rush-redis-healthchecks
9fbe8e8
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Oct 2, 2024 in 13m 47s

3 secrets uncovered!

3 secrets were uncovered from the scan of 250 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #669: develop 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
- - SMTP credentials 3790c89 ops/alpha-deploy.tmpl.yaml View secret
8978162 Triggered Username Password 238a8b5 .env View secret
8978162 Triggered Username Password 29e5cae .env View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.