Merge into main #566
Merged
Merge into main #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that a nil annotation type does not raise a NoMethodError #downcase for nil:Class allowing the more informative error message to be used instead. Closes #561
…otation-type Better error message for invalid annotation type
The 'rows' parameter was defaulting to 10, which was limiting the number of children returned, which was causing instantiations to not be returned for PBCore XML exports and pushes to AAPB. This fixes that, by setting the 'param' to arbitrarily high number. Also, sets rows param for #member_of query.
Tests to see that SolrDocument#members brings back more than 10 children. This is in response to a bugfix where only 10 were being brought back.
…-more-than-10-children Adds spec for SolrDocument#members
orangewolf
pushed a commit
to notch8/ams
that referenced
this pull request
Aug 30, 2022
Merge into main
orangewolf
pushed a commit
to notch8/ams
that referenced
this pull request
Aug 30, 2022
Merge into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger a production release