Fix deployment failure when using an existing ARO cluster #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aro cluster Signed-off-by: Jianguo Ma <[email protected]>
…an deployment resource group Signed-off-by: Jianguo Ma <[email protected]>
Signed-off-by: Jianguo Ma <[email protected]>
Signed-off-by: Jianguo Ma <[email protected]>
… in the end Signed-off-by: Jianguo Ma <[email protected]>
Signed-off-by: Jianguo Ma <[email protected]>
edburns
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to fix #114 (liberty on aro offer deployment failure) which was caused by the issue that the inappropriate check during the pre-filght and missed role assignment on the cluster resource group for the uami of the deployment script, when using an existing ARO cluster.
Test
The deployment succeeded with the fix, see integration-test-72 which deployed a new ARO cluster.
Then I deployed the fix to the testing offer and use its preview link to verify the deployment with the existing ARO cluster, which also succeeded.
Signed-off-by: Jianguo Ma [email protected]