Ensured that dynamic menu items are visible and enabled by default #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a dynamic command and at some point there are no dynamic items to display, then after that point the dynamic menu items will no longer appear, even when there are dynamic items to display.
This occurred because when there are no dynamic items, all of the menu items are hidden and disabled (otherwise you would end up with a single menu item that shouldn't be there). If at some point after that there are dynamic items again, the menu items would remain disabled and hidden unless the
BeforeQueryStatus
handler specifically set the menu item to be enabled and visible.You can reproduce this bug in the test extension (without this fix, of course):