Always try to write attribute to project file if property descriptor is not available #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not available.
|
@madskristensen I think the build failed because it timed out downloading the .NET SDK. Are you able to trigger a rerun? |
|
Triggered a rerun |
|
Any idea when this will be released? |
|
@madskristensen Any chance you could take a look at this? |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a file attribute, if the
VSHPROPID_BrowseObjectproperty could be retrieved, but there wasn't a property descriptor for the specified attribute, then the attribute would not be set. Now, if will always fall back to writing the attribute toIVsBuildPropertyStorage.Related to #383.