Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleaner command attribute check #342

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Add cleaner command attribute check #342

merged 1 commit into from
Jun 1, 2022

Conversation

MariaSolOs
Copy link

@MariaSolOs MariaSolOs commented May 31, 2022 •
edited
Loading

Refactors the CommandAttribute check in BaseCommand to use pattern matching and use GetCustomAttribute instead of GetCustomAttributes. This results in cleaner and safer code, since attr will only be defined when not null.

@madskristensen madskristensen merged commit 9c32305 into VsixCommunity:master Jun 1, 2022
@madskristensen
Copy link
Contributor

Nice. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariaSolOs @madskristensen