Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: investigation on dimforge#532
I moved player_movement to
PostUpdate
because I feel like it's more belonging there, but I'm not too sure about all that.We notice a lot of ambiguities which might be worth investigating.
dotgraph
digraph "" {
"compound"="true";
"splines"="spline";
"rankdir"="LR";
"bgcolor"="#0d1117";
"fontname"="Helvetica";
"nodesep"="0.15";
edge ["penwidth"="2"];
node ["shape"="box", "style"="filled"];
subgraph "clusternode_Set(1)" {
"style"="rounded,filled";
"label"="TransformPropagate";
"tooltip"="TransformPropagate";
"fillcolor"="#ffffff44";
"fontcolor"="#ffffff";
"color"="#ffffff50";
"penwidth"="2";
"set_marker_node_Set(1)" ["style"="invis", "label"="", "height"="0", "shape"="point"]
subgraph "clusternode_Set(0)" {
"style"="rounded,filled";
"label"="PropagateTransformsSet";
"tooltip"="PropagateTransformsSet";
"fillcolor"="#ffffff44";
"fontcolor"="#ffffff";
"color"="#ffffff50";
"penwidth"="2";
"set_marker_node_Set(0)" ["style"="invis", "label"="", "height"="0", "shape"="point"]
"node_System(1)" ["label"="propagate_transforms", "tooltip"="bevy_transform::systems::propagate_transforms", "fillcolor"="#ffe7b9", "fontname"="Helvetica", "fontcolor"="#322100", "color"="#ffc453", "penwidth"="1"]
}
In multiple sets, SyncBackend, RapierTransformPropagateSet", "tooltip"="bevy_transform::systems::sync_simple_transforms"]
"node_System(45)" -> "set_marker_node_Set(56)" ["dir"="none", "color"="blue", "lhead"="clusternode_Set(56)"]
"node_System(45)" -> "set_marker_node_Set(61)" ["dir"="none", "color"="blue", "lhead"="clusternode_Set(61)"]
"node_System(45)" ["label"="propagate_transforms
In multiple sets, SyncBackend, RapierTransformPropagateSet", "tooltip"="bevy_transform::systems::propagate_transforms"]
"set_marker_node_Set(17)" -> "set_marker_node_Set(18)" ["lhead"="clusternode_Set(18)", "ltail"="clusternode_Set(17)", "tooltip"="CalculateBounds → CheckVisibility", "color"="#eede00"]
"set_marker_node_Set(1)" -> "set_marker_node_Set(17)" ["lhead"="clusternode_Set(17)", "ltail"="clusternode_Set(1)", "tooltip"="TransformPropagate → CalculateBounds", "color"="#881877"]
"set_marker_node_Set(12)" -> "set_marker_node_Set(18)" ["lhead"="clusternode_Set(18)", "ltail"="clusternode_Set(12)", "tooltip"="UpdateFrusta → CheckVisibility", "color"="#00b0cc"]
"set_marker_node_Set(1)" -> "set_marker_node_Set(12)" ["lhead"="clusternode_Set(12)", "ltail"="clusternode_Set(1)", "tooltip"="TransformPropagate → UpdateFrusta", "color"="#aa3a55"]
"set_marker_node_Set(19)" -> "set_marker_node_Set(18)" ["lhead"="clusternode_Set(18)", "ltail"="clusternode_Set(19)", "tooltip"="VisibilityPropagate → CheckVisibility", "color"="#44d488"]
"set_marker_node_Set(1)" -> "set_marker_node_Set(19)" ["lhead"="clusternode_Set(19)", "ltail"="clusternode_Set(1)", "tooltip"="TransformPropagate → VisibilityPropagate", "color"="#0090cc"]
"set_marker_node_Set(40)" -> "set_marker_node_Set(41)" ["lhead"="clusternode_Set(41)", "ltail"="clusternode_Set(40)", "tooltip"="AddClusters → AssignLightsToClusters", "color"="#ee9e44"]
"set_marker_node_Set(56)" -> "set_marker_node_Set(1)" ["lhead"="clusternode_Set(1)", "ltail"="clusternode_Set(56)", "tooltip"="SyncBackend → TransformPropagate", "color"="#663699"]
"set_marker_node_Set(57)" -> "set_marker_node_Set(1)" ["lhead"="clusternode_Set(1)", "ltail"="clusternode_Set(57)", "tooltip"="StepSimulation → TransformPropagate", "color"="#3363bb"]
"set_marker_node_Set(56)" -> "set_marker_node_Set(57)" ["lhead"="clusternode_Set(57)", "ltail"="clusternode_Set(56)", "tooltip"="SyncBackend → StepSimulation", "color"="#22c2bb"]
"set_marker_node_Set(58)" -> "set_marker_node_Set(1)" ["lhead"="clusternode_Set(1)", "ltail"="clusternode_Set(58)", "tooltip"="Writeback → TransformPropagate", "color"="#99d955"]
"set_marker_node_Set(57)" -> "set_marker_node_Set(58)" ["lhead"="clusternode_Set(58)", "ltail"="clusternode_Set(57)", "tooltip"="StepSimulation → Writeback", "color"="#eede00"]
"node_System(44)" -> "node_System(45)" ["lhead"="", "ltail"="", "tooltip"="sync_simple_transforms → propagate_transforms", "color"="#881877"]
"node_System(43)" -> "node_System(44)" ["lhead"="", "ltail"="", "tooltip"="update_character_controls → sync_simple_transforms", "color"="#00b0cc"]
"node_System(45)" -> "node_System(46)" ["lhead"="", "ltail"="", "tooltip"="propagate_transforms → init_async_scene_colliders", "color"="#aa3a55"]
"node_System(46)" -> "node_System(47)" ["lhead"="", "ltail"="", "tooltip"="init_async_scene_colliders → init_async_colliders", "color"="#44d488"]
"node_System(47)" -> "node_System(48)" ["lhead"="", "ltail"="", "tooltip"="init_async_colliders → init_rigid_bodies", "color"="#0090cc"]
"node_System(48)" -> "node_System(49)" ["lhead"="", "ltail"="", "tooltip"="init_rigid_bodies → init_colliders", "color"="#ee9e44"]
"node_System(49)" -> "node_System(50)" ["lhead"="", "ltail"="", "tooltip"="init_colliders → init_joints", "color"="#663699"]
"node_System(50)" -> "node_System(51)" ["lhead"="", "ltail"="", "tooltip"="init_joints → sync_removals", "color"="#3363bb"]
"node_System(51)" -> "node_System(52)" ["lhead"="", "ltail"="", "tooltip"="sync_removals → apply_deferred", "color"="#22c2bb"]
"node_System(52)" -> "node_System(53)" ["lhead"="", "ltail"="", "tooltip"="apply_deferred → apply_scale", "color"="#99d955"]
"node_System(53)" -> "node_System(54)" ["lhead"="", "ltail"="", "tooltip"="apply_scale → apply_collider_user_changes", "color"="#eede00"]
"node_System(54)" -> "node_System(55)" ["lhead"="", "ltail"="", "tooltip"="apply_collider_user_changes → apply_rigid_body_user_changes", "color"="#881877"]
"node_System(55)" -> "node_System(56)" ["lhead"="", "ltail"="", "tooltip"="apply_rigid_body_user_changes → apply_joint_user_changes", "color"="#00b0cc"]
"node_System(56)" -> "node_System(57)" ["lhead"="", "ltail"="", "tooltip"="apply_joint_user_changes → apply_initial_rigid_body_impulses", "color"="#aa3a55"]
"set_marker_node_Set(1)" -> "node_System(62)" ["lhead"="", "ltail"="clusternode_Set(1)", "tooltip"="TransformPropagate → debug_render_scene", "color"="#44d488"]
"node_System(63)" -> "set_marker_node_Set(58)" ["lhead"="clusternode_Set(58)", "ltail"="", "tooltip"="player_movement → Writeback", "color"="#0090cc"]
"set_marker_node_Set(57)" -> "node_System(63)" ["lhead"="", "ltail"="clusternode_Set(57)", "tooltip"="StepSimulation → player_movement", "color"="#ee9e44"]
"node_System(42)" -> "node_System(51)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(54)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(55)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(56)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(57)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(58)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(60)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(61)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(42)" -> "node_System(62)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(43)" -> "node_System(42)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(48)" -> "node_System(42)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(49)" -> "node_System(42)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(50)" -> "node_System(42)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
"node_System(60)" -> "node_System(61)" ["dir"="none", "constraint"="false", "color"="#c93526", "fontcolor"="#c93526", "label"=<
}