perf: only format model values if writing text model #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
approved these changes
Jun 9, 2023
jackgerrits
added a commit
to VowpalWabbit/py-vowpal-wabbit-next
that referenced
this pull request
Jun 9, 2023
…el (#85) After implementing this change a 190MB model when from taking 63.26s to 9.11s to serialize. Additionally, VowpalWabbit/vowpal_wabbit#4613 also drastically improves the situation. #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing adding this fix reduced model saving time from 9.11s to 2.08s for a 190MB model.