refactor: make flat_example an implementation detail of ksvm #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassmang
reviewed
Feb 22, 2023
| float linear_kernel(const VW::flat_example* fec1, const VW::flat_example* fec2) | ||
| { | ||
| float dotprod = 0; | ||
| // float linear_kernel(const VW::flat_example* fec1, const VW::flat_example* fec2) |
bassmang
approved these changes
Feb 27, 2023
lalo
added a commit
that referenced
this pull request
Mar 20, 2023
commit adcaff2 Author: Marek Wydmuch <[email protected]> Date: Mon Mar 20 15:30:30 2023 +0100 feat: add a training loss calculation to the predict method of PLT reduction (#4534) * add a training loss calculation to the predict method of PLT reduction * update PLT demo * update the tests for PLT reduction * disable the calculation of additional evaluation measures in PLT reduction when true labels are not available * apply black formating to plt_demo.py * remove unnecessary reset of weighted_holdout_examples variable in PLT reduction * revert the change of the path to the exe in plt_demo.py * apply black formating again to plt_demo.py --------- Co-authored-by: Jack Gerrits <[email protected]> commit f7a197e Author: Griffin Bassman <[email protected]> Date: Fri Mar 17 11:01:17 2023 -0400 refactor: separate cb_to_cs_adf_mtr and cb_to_cs_adf_dr (#4532) * refactor: separate cb_to_cs_adf_mtr and cb_to_cs_adf_dr * clang * unused * remove mtr commit e5597ae Author: swaptr <[email protected]> Date: Fri Mar 17 02:21:50 2023 +0530 fix: fix multiline typo (#4533) commit 301800a Author: Eduardo Salinas <[email protected]> Date: Wed Mar 15 12:25:55 2023 -0400 test: [automl] improve runtest and test changes (#4531) commit 258731c Author: Griffin Bassman <[email protected]> Date: Tue Mar 14 13:28:03 2023 -0400 chore: Update Version to 9.5.0 (#4529) commit 49131be Author: Eduardo Salinas <[email protected]> Date: Tue Mar 14 11:03:24 2023 -0400 fix: [automl] avoid ccb pulling in generate_interactions (#4524) * fix: [automl] avoid ccb pulling in generate_interactions * same features in one line minimal repro * add assert of reserve size * update test file * remove include and add comment * temp print * sorting interactions matters * update temp print * fix by accounting for slot ns * remove prints * change comment and remove commented code * add sort to test * update runtests * Squashed commit of the following: commit 322a2b1 Author: Eduardo Salinas <[email protected]> Date: Mon Mar 13 21:51:49 2023 +0000 possibly overwrite vw brought in by vw-executor commit 0a6baa0 Author: Eduardo Salinas <[email protected]> Date: Mon Mar 13 21:25:46 2023 +0000 add check for metrics commit 469cebe Author: Eduardo Salinas <[email protected]> Date: Mon Mar 13 21:22:38 2023 +0000 update test commit 7c0b212 Author: Eduardo Salinas <[email protected]> Date: Mon Mar 13 21:11:45 2023 +0000 format and add handler none commit 533e067 Author: Eduardo Salinas <[email protected]> Date: Mon Mar 13 20:56:07 2023 +0000 test: [automl] add ccb test that checks for ft names * update python test * Update automl_oracle.cc commit 37f4b19 Author: Griffin Bassman <[email protected]> Date: Fri Mar 10 17:38:02 2023 -0500 refactor: remove resize in gd setup (#4526) * refactor: remove resize in gd setup * rm resize commit 009831b Author: Griffin Bassman <[email protected]> Date: Fri Mar 10 16:57:53 2023 -0500 fix: multi-model state for cb_adf (#4513) * switch to vector * fix aml and ep_dec * clang * reorder * clang * reorder commit a31ef14 Author: Griffin Bassman <[email protected]> Date: Fri Mar 10 14:52:50 2023 -0500 refactor: rename wpp, ppw, ws, params_per_problem, problem_multiplier, num_learners, increment -> feature_width (#4521) * refactor: rename wpp, ppw, ws, params_per_problem, problem_multiplier, num_learners, increment -> interleaves * clang * clang * settings * make bottom interleaves the same * remove bottom_interleaves * fix test * feature width * clang commit 8390f48 Author: Griffin Bassman <[email protected]> Date: Fri Mar 10 12:25:12 2023 -0500 refactor: dedup dict const (#4525) * refactor: dedup dict const * clang commit 2238d70 Author: Jack Gerrits <[email protected]> Date: Thu Mar 9 13:51:35 2023 -0500 refactor: add api to set data object associated with learner (#4523) * refactor: add api to set data object associated with learner * add shared ptr func commit b622540 Author: Griffin Bassman <[email protected]> Date: Tue Mar 7 12:16:39 2023 -0500 fix: cbzo ppw fix (#4519) commit f83cb7f Author: Jack Gerrits <[email protected]> Date: Tue Mar 7 11:21:51 2023 -0500 refactor: automatically set label parser after stack created (#4471) * refactor: automatically set label parser after stack created * a couple of fixes * Put in hack to keep search working * formatting commit 64e5920 Author: olgavrou <[email protected]> Date: Fri Mar 3 16:20:05 2023 -0500 feat: [LAS] with CCB (#4520) commit 69bf346 Author: Jack Gerrits <[email protected]> Date: Fri Mar 3 15:17:29 2023 -0500 refactor: make flat_example an implementation detail of ksvm (#4505) * refactor!: make flat_example an implementation detail of ksvm * Update memory_tree.cc * Absorb flat_example into svm_example * revert "Absorb flat_example into svm_example" This reverts commit b063feb. commit f08f1ec Author: Jack Gerrits <[email protected]> Date: Fri Mar 3 14:04:48 2023 -0500 test: fix pytype issue in test runner and utl (#4517) * test: fix pytype issue in test runner * fix version_number.py type checker issues commit a8b1d91 Author: Eduardo Salinas <[email protected]> Date: Fri Mar 3 12:59:26 2023 -0500 fix: [epsdecay] return champ prediction always (#4518) commit b2276c1 Author: olgavrou <[email protected]> Date: Thu Mar 2 20:18:23 2023 -0500 chore: [LAS] don't force mtr with LAS (#4516) commit c0ba180 Author: olgavrou <[email protected]> Date: Tue Feb 28 11:27:36 2023 -0500 feat: [LAS] add example ft hash and cache and re-use rows of matrix if actions do not change (#4509) commit e1a9363 Author: Eduardo Salinas <[email protected]> Date: Mon Feb 27 16:35:09 2023 -0500 feat: [gd] persist ppw extra state (#4023) * feat: [gd] persist ppm state * introduce resize_ppw_state * wip: move logic down to gd, respect incoming ft_offset * replace assert with status quo behaviour * implement writing/reading to modelfile * remove from predict * update test 351 and 411 * update sensitivity and update * remove debug prints * update all tests * apply fix of other pr * use .at() for bounds checking * add max_ft_offset and add asserts * comment extra assert that is failing * remove files * fix automl tests * more tests * tests * tests * clang * fix for predict_only_model automl * comment * fix ppm printing * temporarily remove tests 50 and 68 * address comments * expand width for search * fix tests * merge * revert cb_adf * merge * fix learner * clang * search fix * clang * fix unit tests * bump 9.7.1 for version CIs * revert to 9.7.0 * stop search from learning out of bounds * expand search num_learners * fix search cs test * comment * revert ext_libs * clang * comment out saveresume tests * pylint * comment * fix with search * fix search * clang * unused * unused * commnets * fix scope_exit * fix cs test * revert automl test update * remove resize * clang --------- Co-authored-by: Griffin Bassman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use of
flat_exampleis to easily calculate the dot produce of two examples. Therefore, I added functionality to better reflect that. KSVM is pretty complex so I didn't go all out there, butflat_exampleis now an implementation detail.Additionally, KSVM depends on the cache representation for its model file which is an issue because the cache by definition can change. So there is a TODO to fix that.