feat: [LAS] filter out (potentially) more actions than d based on singular values #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
commented
Oct 19, 2022
| @@ -138,12 +138,6 @@ BOOST_AUTO_TEST_CASE(check_AO_linear_combination_of_actions) | |||
| vw.finish_example(examples); | |||
| } | |||
|
|
|||
| // After the decomposition, the linear combination in the representation of the action in U is maintained for the | |||
There was a problem hiding this comment.
this is taken care of by the core algo now
jackgerrits
approved these changes
Oct 19, 2022
zwd-ms
reviewed
Oct 19, 2022
| @@ -40,8 +40,8 @@ void spanner_state::compute_spanner(const Eigen::MatrixXf& U, size_t _d, const s | |||
| // Awerbuch & Kleinberg STOC'04: https://www.cs.cornell.edu/~rdk/papers/OLSP.pdf | |||
|
|
|||
| // The size of U is K x d, where K is the total number of all actions. | |||
| _X.setIdentity(_d, _d); | ||
| _X_inv.setIdentity(_d, _d); | ||
| assert(static_cast<uint64_t>(U.cols()) >= _d); | ||
| _X.setIdentity(_d, U.cols()); |
There was a problem hiding this comment.
for example, shall this be _X.setIdentity(U.cols(), U.cols())?
| @@ -100,9 +100,9 @@ void one_rank_spanner_state::compute_spanner( | |||
| */ | |||
|
|
|||
| // The size of U is K x d, where K is the total number of all actions | |||
There was a problem hiding this comment.
Because U may have more columns than d, i suppose we need to use U.cols() in place of d consistently in spanner computation?
Also need to update the comment here.
There was a problem hiding this comment.
synced offline, U is truncated to d before it is returned from one_pass_svd and updated naming in spanner to make things clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_actions~ > than the matrix rank we don't have to tunenum_actionssince results should be the same0)