Master #3
Open
Master #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged corrected result from hw1 branch to master
Added routes and basic design
|
|
||
| export default class CalendarDay extends React.Component { | ||
| render() { | ||
| let curDay = new Date(this.props.info.year, this.props.info.month, this.props.info.day); |
There was a problem hiding this comment.
move info to own variable, you using this.props.info too much.
| </Header> | ||
| <Sidebar> | ||
| <button className='btn' onClick={() => this.props.chgDay(-1)}>Prev day</button> | ||
| <button className='btn' onClick={() => this.props.chgDay(-2)}>Next day</button> |
There was a problem hiding this comment.
why next day is -2?
| if (numOfDaysFromBegOfWeek !== 6) { | ||
| for (let j = 1; j <= numOfDaysFromBegOfWeek + 1; j++) { | ||
| arr.push({ | ||
| date: (-1) * j, |
|
|
||
| } | ||
|
|
||
| changeMonth = (what) => { |
There was a problem hiding this comment.
this function is totally counter-intuitive, please refactor this. :)
| } | ||
| } | ||
|
|
||
| isOkDay = (day) => { |
There was a problem hiding this comment.
I think you can reduce size of this function if you investigate working with Date objects more :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrote project using classes