Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Record NCCO Behaviour #493

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Aug 9, 2024

The SDK sets the default timeout to the max of 7200, which breaks the sync/async behaviour.

Description

Developers now have the choice to set a timeout, or it is null. Use $ncco->setTimeout(3400) to do this.

How Has This Been Tested?

Tests modified to pass.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… specify the time, developers need choice on whether to set it
@SecondeJK SecondeJK merged commit eb73c22 into main Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant