Remove a load of traits not being used by anything #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecondeJK
added a commit
that referenced
this pull request
Jun 24, 2024
SecondeJK
added a commit
that referenced
this pull request
Jun 28, 2024
* Finished GNP Auth and SimSwap MVP implementation * Add documentation * init * Add next workflow to SDK (#476) * Add from validation on request (#477) * Feature/conversations (#478) * WIP * WIP * WIP * WIP * WIP * refactor to remove attempt at putting all event objects in * Added docs * phpstan fix number object * Update README.md 8.1 is minimum * Remove Orphaned Code (#480) * Big cleanup of unused internals * clean some unused imports * Fix baseline, mark some deprecations coming * fix ConversationClientFactory (#479) Co-authored-by: yosh <[email protected]> * Remove a load of traits not being used by anything (#481) * bring psr7 trait back (#482) * Finished GNP Auth and SimSwap MVP implementation (#475) * Finished GNP Auth and SimSwap MVP implementation * Add documentation * PSR-4 fix * clean imports * Finished GNP Auth and SimSwap MVP implementation * bring psr7 trait back (#482) * Fix broken git history * Bulk of work pre-testing * Testing complete * Configure scopes correctly within the client, remove rogue die statement --------- Co-authored-by: Yoshitaka Takeuchi <[email protected]> Co-authored-by: yosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In further preparation for internals shifting for v5.0 of this library, a load of unused internal traits have been deleted.
Description
The following dead traits have been removed:
ArrayAccessTrait (this is covered by APIResource)
CollectionAwareInterface (this is covered by IterableAPICollection)
CollectionAwareTrait (this is covered by IterableAPICollection)
CollectionInterface (this is covered by IterableAPICollection)
CollectionTrait (this is covered by IterableAPICollection)
ModernCollectionTrait (this is covered by IterableAPICollection)
Motivation and Context
Further preparation for internals shifting for v5.0 of this library.
How Has This Been Tested?
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: