Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove verification checks, API behaviour too unstable currently #449

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Oct 23, 2023

This PR removes the server-side SDK check for supported locales on the basis that the Verify V2 API currently has some unexpected behaviour.

Description

You now supply a locale - if you don't, en-us is chosen. At the time of writing, the Vonage API will scan the to field in a workflow and choose your locale for you.

Motivation and Context

Attempt to get some consistency - right now, the emphasis here is for the API to handle error handling rather than the SDK to do it at the time of execution (before a call is made)

How Has This Been Tested?

Test to make sure you can give a valid locale has been removed.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #449 (a1af21a) into main (c598f9b) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #449      +/-   ##
============================================
- Coverage     78.92%   78.91%   -0.01%     
+ Complexity     2324     2323       -1     
============================================
  Files           218      218              
  Lines          6248     6246       -2     
============================================
- Hits           4931     4929       -2     
  Misses         1317     1317              
Files Coverage Δ
src/Verify2/VerifyObjects/VerificationLocale.php 50.00% <ø> (-12.50%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SecondeJK SecondeJK merged commit e472cad into main Oct 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants