Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to JWT library #441

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Refactor to JWT library #441

merged 3 commits into from
Oct 11, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Oct 9, 2023

This PR marks the first move to remove the dependency for lcobucci/jwt to vonage/jwt.

Description

While vonage/jwt still uses lcobucci/jwt under the hood, I am extracting it as a dependency for core so that the vonage/jwt library can firstly be reused for other projects that require vonage-specifc JWTs.

Motivation and Context

Preparing core for v5.0 by adjusting dependencies.

How Has This Been Tested?

Existing tests pass.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK self-assigned this Oct 9, 2023
@SecondeJK SecondeJK added enhancement release-candidate This PR will result in a release labels Oct 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #441 (fdd9215) into main (9ebd564) will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##               main     #441      +/-   ##
============================================
+ Coverage     78.87%   78.92%   +0.04%     
  Complexity     2324     2324              
============================================
  Files           218      218              
  Lines          6253     6248       -5     
============================================
- Hits           4932     4931       -1     
+ Misses         1321     1317       -4     
Files Coverage Δ
src/Client/Credentials/Keypair.php 91.17% <94.44%> (+9.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SecondeJK SecondeJK mentioned this pull request Oct 10, 2023
9 tasks
@SecondeJK SecondeJK merged commit 6c22785 into main Oct 11, 2023
8 checks passed
@erickskrauch erickskrauch mentioned this pull request Oct 13, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release-candidate This PR will result in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants