Autoload video module if it is installed (#458)

Vonage · Dec 12, 2023 · 2c8d6b4 · 2c8d6b4
1 parent 5021494
commit 2c8d6b4
Show file tree

Hide file tree

Showing 2 changed files with 64 additions and 21 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -90,6 +90,7 @@
  * @method Verify\Client  verify()
  * @method Verify2\Client  verify2()
  * @method Voice\Client voice()
+ * @method Vonage\Video\Client video()
  *
  * @property string restUrl
  * @property string apiUrl
@@ -211,29 +212,39 @@ public function __construct(
             $this->debug = $options['debug'];
         }
 
+        $services = [
+            // Registered Services by name
+            'account' => ClientFactory::class,
+            'applications' => ApplicationClientFactory::class,
+            'conversion' => ConversionClientFactory::class,
+            'insights' => InsightsClientFactory::class,
+            'numbers' => NumbersClientFactory::class,
+            'meetings' => MeetingsClientFactory::class,
+            'messages' => MessagesClientFactory::class,
+            'redact' => RedactClientFactory::class,
+            'secrets' => SecretsClientFactory::class,
+            'sms' => SMSClientFactory::class,
+            'subaccount' => SubaccountClientFactory::class,
+            'users' => UsersClientFactory::class,
+            'verify' => VerifyClientFactory::class,
+            'verify2' => Verify2ClientFactory::class,
+            'voice' => VoiceClientFactory::class,
+
+            // Additional utility classes
+            APIResource::class => APIResource::class,
+        ];
+
+        if (class_exists('Vonage\Video\ClientFactory')) {
+            $services['video'] = 'Vonage\Video\ClientFactory';
+        } else {
+            $services['video'] = function() {
+                throw new \RuntimeException('Please install @vonage/video to use the Video API');
+            };
+        }
+
         $this->setFactory(
             new MapFactory(
-                [
-                    // Registered Services by name
-                    'account' => ClientFactory::class,
-                    'applications' => ApplicationClientFactory::class,
-                    'conversion' => ConversionClientFactory::class,
-                    'insights' => InsightsClientFactory::class,
-                    'numbers' => NumbersClientFactory::class,
-                    'meetings' => MeetingsClientFactory::class,
-                    'messages' => MessagesClientFactory::class,
-                    'redact' => RedactClientFactory::class,
-                    'secrets' => SecretsClientFactory::class,
-                    'sms' => SMSClientFactory::class,
-                    'subaccount' => SubaccountClientFactory::class,
-                    'users' => UsersClientFactory::class,
-                    'verify' => VerifyClientFactory::class,
-                    'verify2' => Verify2ClientFactory::class,
-                    'voice' => VoiceClientFactory::class,
-
-                    // Additional utility classes
-                    APIResource::class => APIResource::class,
-                ],
+                $services,
                 $this
             )
         );

diff --git a/test/ClientTest.php b/test/ClientTest.php
@@ -0,0 +1,32 @@
+<?php
+
+/**
+ * Vonage Client Library for PHP
+ *
+ * @copyright Copyright (c) 2016-2023 Vonage, Inc. (http://vonage.com)
+ * @license https://github.com/Vonage/vonage-php-sdk-core/blob/master/LICENSE.txt Apache License 2.0
+ */
+
+declare(strict_types=1);
+
+namespace VonageTest;
+
+use RuntimeException;
+use VonageTest\VonageTestCase;
+use Vonage\Client;
+use Vonage\Client\Credentials\Basic;
+
+class ClientTest extends VonageTestCase
+{
+    /**
+     * Make sure that when calling the video module it errors if the class isn't found
+     */
+    public function testCallingVideoWithoutPackageGeneratesRuntimeError(): void
+    {
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Please install @vonage/video to use the Video API');
+
+        $client = new Client(new Basic('abcd', '1234'));
+        $video = $client->video();
+    }    
+}