Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(media): support for the media api #857

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat(media): support for the media api #857

merged 1 commit into from
Oct 13, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Aug 16, 2023

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #857 (b19b2ef) into 3.x (670b83c) will increase coverage by 0.22%.
Report is 1 commits behind head on 3.x.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #857      +/-   ##
==========================================
+ Coverage   83.87%   84.10%   +0.22%     
==========================================
  Files         121      122       +1     
  Lines        1619     1642      +23     
  Branches      311      314       +3     
==========================================
+ Hits         1358     1381      +23     
  Misses        260      260              
  Partials        1        1              
Files Coverage Δ
packages/media/lib/media.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck marked this pull request as ready for review August 16, 2023 15:43
@manchuck manchuck force-pushed the media-package branch 2 times, most recently from 8f88259 to fd40baa Compare October 11, 2023 18:39
@manchuck manchuck changed the title feat: media package feat(media): support for the media api Oct 11, 2023
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit 5ca15c8 into 3.x Oct 13, 2023
11 checks passed
@manchuck manchuck deleted the media-package branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants