Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: users package #845

Merged
merged 1 commit into from
Aug 14, 2023
Merged

feat: users package #845

merged 1 commit into from
Aug 14, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jul 26, 2023

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck force-pushed the feat-users branch 4 times, most recently from 09d7408 to fb0a582 Compare July 31, 2023 21:20
@manchuck manchuck marked this pull request as ready for review July 31, 2023 21:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #845 (06f0aa4) into 3.x (3398e96) will increase coverage by 0.62%.
Report is 1 commits behind head on 3.x.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #845      +/-   ##
==========================================
+ Coverage   83.52%   84.14%   +0.62%     
==========================================
  Files         119      120       +1     
  Lines        1493     1552      +59     
  Branches      284      299      +15     
==========================================
+ Hits         1247     1306      +59     
  Misses        245      245              
  Partials        1        1              
Files Changed Coverage Δ
packages/user/lib/user.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck force-pushed the feat-users branch 8 times, most recently from 1b35b5a to 06f0aa4 Compare August 9, 2023 17:28
@manchuck manchuck removed the request for review from conshus August 9, 2023 17:31
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would change the update user method though

packages/user/lib/user.ts Outdated Show resolved Hide resolved
packages/user/lib/user.ts Outdated Show resolved Hide resolved
@manchuck manchuck merged commit 4f623b5 into 3.x Aug 14, 2023
11 checks passed
@manchuck manchuck deleted the feat-users branch August 14, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants