Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Header auth in SmsClient #555

Merged
merged 6 commits into from
Dec 2, 2024
Merged

refactor: Use Header auth in SmsClient #555

merged 6 commits into from
Dec 2, 2024

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Dec 2, 2024

Replaces usages of ApiKeyQueryParamsAuthMethod with ApiKeyHeaderAuthMethod where possible.

@SMadani SMadani force-pushed the auth branch 3 times, most recently from 0f2cdde to f2f2b9b Compare December 2, 2024 17:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (fe06b81) to head (24b3d00).
Report is 70 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #555      +/-   ##
============================================
+ Coverage     95.60%   95.99%   +0.39%     
- Complexity     3427     3752     +325     
============================================
  Files           513      564      +51     
  Lines          8141     8699     +558     
  Branches        451      496      +45     
============================================
+ Hits           7783     8351     +568     
+ Misses          198      175      -23     
- Partials        160      173      +13     
Files with missing lines Coverage Δ
...rc/main/java/com/vonage/client/AbstractMethod.java 100.00% <100.00%> (+22.22%) ⬆️
...com/vonage/client/auth/ApiKeyHeaderAuthMethod.java 100.00% <ø> (ø)
.../java/com/vonage/client/insight/InsightClient.java 100.00% <100.00%> (ø)
src/main/java/com/vonage/client/sms/SmsClient.java 100.00% <100.00%> (ø)

... and 33 files with indirect coverage changes

@SMadani SMadani marked this pull request as ready for review December 2, 2024 17:20
@SMadani SMadani changed the title refactor: Replace query params auth with Header refactor: Use Header auth in SmsClient Dec 2, 2024
@SMadani SMadani merged commit 17f5f10 into main Dec 2, 2024
17 checks passed
@SMadani SMadani deleted the auth branch December 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants