Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DynamicEndpoint for Video API #503

Merged
merged 7 commits into from
Dec 21, 2023
Merged

refactor: DynamicEndpoint for Video API #503

merged 7 commits into from
Dec 21, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Dec 21, 2023

Finishes the migration to DynamicEndpoint for Video API, just like with other APIs that have been refactored.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Merging #503 (d90251b) into main (1d3f62c) will decrease coverage by 0.28%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #503      +/-   ##
============================================
- Coverage     94.61%   94.34%   -0.28%     
+ Complexity     2864     2755     -109     
============================================
  Files           422      399      -23     
  Lines          6911     6651     -260     
  Branches        440      436       -4     
============================================
- Hits           6539     6275     -264     
- Misses          200      203       +3     
- Partials        172      173       +1     
Files Coverage Δ
.../com/vonage/client/video/CreateSessionRequest.java 100.00% <ø> (ø)
...ge/client/video/ListStreamCompositionsRequest.java 100.00% <ø> (ø)
...a/com/vonage/client/video/MuteSessionResponse.java 100.00% <100.00%> (ø)
...main/java/com/vonage/client/video/VideoClient.java 99.31% <100.00%> (+0.06%) ⬆️
...om/vonage/client/video/VideoResponseException.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@SMadani SMadani marked this pull request as ready for review December 21, 2023 17:55
@SMadani SMadani merged commit 8cdb975 into main Dec 21, 2023
12 checks passed
@SMadani SMadani deleted the video-refactor branch December 21, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants