Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): Fix build issue with OutputArgs #47

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

kellyjandrews
Copy link
Contributor

This PR fixes an issue with the OutputArgs that somehow snuck back in and broke the build.

@kellyjandrews kellyjandrews added the bug Something isn't working label Jan 25, 2022
@kellyjandrews kellyjandrews self-assigned this Jan 25, 2022
@kellyjandrews
Copy link
Contributor Author

Resolve this PR prior to #46

@SecondeJK
Copy link
Contributor

Tested and lerna run build completes successfully

Copy link
Contributor

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug: ship it!

@kellyjandrews kellyjandrews merged commit 73671ee into main Jan 26, 2022
@kellyjandrews kellyjandrews deleted the fix/applications-link branch January 26, 2022 14:51
kellyjandrews added a commit that referenced this pull request Jan 27, 2022
* chore(conversations): Update typescript config

* chore(conversations): Replace test harness

* fix(conversations): add unit tests

* fix(conversations): update commands

* fix(conversations): Add proper error handling

* fix(utils): Fix build issue with OutputArgs (#47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants