Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shapefile): spaces in name no longer cause the crash #593

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Oct 21, 2021

I don't really understand why this was causing troubles when I was at it previously. Could be some related changes were messing up.

@vercel
Copy link

vercel bot commented Oct 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/DysVdBppNC6K2Daapi1oSf8JpJBV
✅ Preview: https://marxan-git-fix-shapefile-with-spaces-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/4a2cMo2mCHSQGdqQEMrpfZWRqzW3
✅ Preview: https://marxan-storybook-git-fix-shapefile-with-spaces-vizzuality1.vercel.app

@kgajowy kgajowy marked this pull request as ready for review October 21, 2021 14:32
Copy link
Member

@hotzevzl hotzevzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, the joys of shell quote escaping... I can foresee this breaking for clever users' clever filenaming strategies, but it should also be good enough. Alternatively we'd need to replace on the fly any characters that may lead to trouble (\s"'() and so on) before even writing the file to disk - I'd avoid this for now though.

@kgajowy
Copy link
Contributor Author

kgajowy commented Oct 22, 2021

ah, the joys of shell quote escaping... I can foresee this breaking for clever users' clever filenaming strategies, but it should also be good enough. Alternatively we'd need to replace on the fly any characters that may lead to trouble (\s"'() and so on) before even writing the file to disk - I'd avoid this for now though.

Tried it previously - replacing within multer uploader already but it caused further issues... but could be the same reason as in PR description - some other change caused this. 😬

@kgajowy kgajowy merged commit 6f01e92 into develop Oct 22, 2021
@kgajowy kgajowy deleted the fix/shapefile-with-spaces branch October 22, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants