Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details of maps - what should be visible on each #588

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

hotzevzl
Copy link
Member

https://vizzuality.atlassian.net/browse/MARXAN-767

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/Db4zHMmPq8uD39bzYBEsrmYVLUDs
✅ Preview: https://marxan-git-docs-productmarxan-767review-of-m-fbd988-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/9yaafNDrz9FVums8dPosdiceMagN
✅ Preview: https://marxan-storybook-git-docs-productmarxan-767r-fa3216-vizzuality1.vercel.app

Copy link
Contributor

@kgajowy kgajowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hotzevzl looks good to me. Are we currently missing any of the elements that should be visible?

@hotzevzl
Copy link
Member Author

@hotzevzl looks good to me. Are we currently missing any of the elements that should be visible?

in the last week or so, I have experienced missing features (Planning units where at least one feature is present are highlighted (indigo)) occasionally in pre-gap analysis. That was puzzling as IIRC the project where I saw this was created afresh on a branch that had all the most recent logic about pre-calculating which PUs "contain" which features, though once I created a new project in the same instance, same branch, all was being displayed correctly. So that's something to keep an eye on in case it happens again and we can reproduce it.

@hotzevzl
Copy link
Member Author

@hotzevzl looks good to me. Are we currently missing any of the elements that should be visible?

in the last week or so, I have experienced missing features (Planning units where at least one feature is present are highlighted (indigo)) occasionally in pre-gap analysis. That was puzzling as IIRC the project where I saw this was created afresh on a branch that had all the most recent logic about pre-calculating which PUs "contain" which features, though once I created a new project in the same instance, same branch, all was being displayed correctly. So that's something to keep an eye on in case it happens again and we can reproduce it.

there may actually be something happening with z-index (or whatever applies in this context) in the frontend, as I am doing some unrelated checks now and features are highlighted or lowlighted depending on what else is high/low-lighted. I'll open a bug if I can pinpoint things more precisely.

@hotzevzl hotzevzl merged commit a5ec23f into develop Oct 21, 2021
@tiagojsag tiagojsag deleted the docs/product/MARXAN-767_review-of-map-content branch February 11, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants