-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(geo-features): remove unused code #565
refactor(geo-features): remove unused code #565
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/7tyUKBgNCwHhfNzG7uuB99Y7w6Zs marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/B2ZkECt9sAaGoGFpeM3u6eT2g3hH |
ef20afc
to
9c506e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also "downgrade" the v2 endpoint to the path of the ones we're removing here?
This will need updating in app/hooks/features/index.ts
too - would you be ok with this tiny cleanup on both API and app side @mbarrenechea? Just to avoid having this v2 path component sticking out for no obvious reason since we don't need to provide backwards compatibility with the "v1" endpoints.
|
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)