Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(geo-features): remove unused code #565

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Oct 11, 2021

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Oct 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/7tyUKBgNCwHhfNzG7uuB99Y7w6Zs
✅ Preview: https://marxan-git-refactor-marxan-675-remove-geofea-332b1d-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/B2ZkECt9sAaGoGFpeM3u6eT2g3hH
✅ Preview: https://marxan-storybook-git-refactor-marxan-675-rem-79835f-vizzuality1.vercel.app

Copy link
Member

@hotzevzl hotzevzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also "downgrade" the v2 endpoint to the path of the ones we're removing here?

This will need updating in app/hooks/features/index.ts too - would you be ok with this tiny cleanup on both API and app side @mbarrenechea? Just to avoid having this v2 path component sticking out for no obvious reason since we don't need to provide backwards compatibility with the "v1" endpoints.

@kgajowy
Copy link
Contributor Author

kgajowy commented Oct 13, 2021

Should we also "downgrade" the v2 endpoint to the path of the ones we're removing here?

This will need updating in app/hooks/features/index.ts too - would you be ok with this tiny cleanup on both API and app side @mbarrenechea? Just to avoid having this v2 path component sticking out for no obvious reason since we don't need to provide backwards compatibility with the "v1" endpoints.

@mbarrenechea ?

@mbarrenechea
Copy link
Member

@hotzevzl @kgajowy What you mean is to change this endpoint /${id}/features/specification/v2 to this one /${id}/features/specification?

@kgajowy
Copy link
Contributor Author

kgajowy commented Oct 13, 2021

@hotzevzl @kgajowy What you mean is to change this endpoint /${id}/features/specification/v2 to this one /${id}/features/specification?

yep, possibly within this PR - in both places (will require manual deploy on API tho)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants