-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): include async job status in all relevant endpoints #539
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/478PkuYnHDcymEypRkLQ7BBjo77U marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/BnrkRut9zdgshtd6PP8PsEArzqfu |
0ea4f36
to
7ffd5ac
Compare
7ffd5ac
to
bef5d13
Compare
bef5d13
to
f5f56e8
Compare
f5f56e8
to
8f452e2
Compare
yep, I have created a task to track this (https://vizzuality.atlassian.net/browse/MARXAN-792) - I'd hold on for the moment, unless the mixing of meta becomes an actual issue that affects ability to send reliable data in responses. |
@kgajowy I would maybe add a technical debt comment in the code itself, as a caveat to our future selves touching pagination or other meta - you can decide if it's worth it. |
8f452e2
to
32f7ffd
Compare
We should be carefully when serializing stuff.
plainToClass
removes itWe should consider redesign of creating OpenApi definitions, meta inclusion/mixing, responsibilities and serialization itself.
PROJECTS
Async jobs
Non-async jobs
SCENARIOS
Async jobs
Non-async jobs