fix(marxan-run): in case of any error, handle it and use failed-reason #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/5B5qCQh871fCb7uJiE8w9NjZRBt9 marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/3QP6rEE7m6ssrGFd45FcdFToxrUm |
kgajowy
force-pushed
the
fix/marxan-run-fails
branch
from
92c5ad0
to
de6932e
Compare
kgajowy
force-pushed
the
fix/marxan-run-fails
branch
from
de6932e
to
54b4618
Compare
kgajowy
requested review from
hotzevzl and
Dyostiq
and removed request for
hotzevzl
Dyostiq
approved these changes
Sep 2, 2021
Comment on lines
54
to
60
| error: Error & { | ||
| errno: number; | ||
| code: number; | ||
| path: string; | ||
| syscall: string; | ||
| spawnargs: string[]; | ||
| }, |
There was a problem hiding this comment.
Suggested change
| error: Error & { | |
| errno: number; | |
| code: number; | |
| path: string; | |
| syscall: string; | |
| spawnargs: string[]; | |
| }, | |
| error: Error | { | |
| errno: number; | |
| code: number; | |
| path: string; | |
| syscall: string; | |
| spawnargs: string[]; | |
| }, |
otherwise the 'code' in error doesn't make sense
hotzevzl
approved these changes
Sep 2, 2021
kgajowy
force-pushed
the
fix/marxan-run-fails
branch
from
54b4618
to
e6562fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for using
stringwithinnew Error(...)is thatbullmqassumes such format so that the job data containsfailedReasonproperty derived from this very type (i.e. if processor finished throwing an error)source: taskforcesh/bullmq#537 (comment)