Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): keep only current specification data in the table for proce… #493

Merged
merged 2 commits into from
Aug 27, 2021
Merged

fix(api): keep only current specification data in the table for proce… #493

merged 2 commits into from
Aug 27, 2021

Conversation

Dyostiq
Copy link
Contributor

@Dyostiq Dyostiq commented Aug 25, 2021

…ssing

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets

Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Aug 25, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/AvW64dZRrexASs6p7B9zGLdV6uZe
✅ Preview: https://marxan-git-fix-marxan-687-keep-only-current-9d1bf5-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/Bz651xwFMfHsQ3vJKLqLkrYCcqaj
✅ Preview: https://marxan-storybook-git-fix-marxan-687-keep-onl-64db24-vizzuality1.vercel.app

@Dyostiq Dyostiq force-pushed the fix/MARXAN-687-keep-only-current-spec-data-for-processing branch from cedfc5b to 1d14361 Compare August 25, 2021 14:37
@Dyostiq Dyostiq force-pushed the fix/MARXAN-687-keep-only-current-spec-data-for-processing branch from 1d14361 to d8f95ec Compare August 26, 2021 14:17
@Dyostiq Dyostiq force-pushed the fix/MARXAN-687-keep-only-current-spec-data-for-processing branch from d8f95ec to e1c1693 Compare August 26, 2021 14:20
@Dyostiq Dyostiq force-pushed the fix/MARXAN-687-keep-only-current-spec-data-for-processing branch from 1438e45 to 7cde07c Compare August 26, 2021 14:29
@Dyostiq Dyostiq marked this pull request as ready for review August 26, 2021 14:42
@Dyostiq Dyostiq requested a review from kgajowy August 26, 2021 14:42
kgajowy
kgajowy approved these changes Aug 27, 2021
View reviewed changes
api/apps/api/src/modules/scenarios-features/index.ts
@@ -2,3 +2,4 @@ export { ScenarioFeaturesModule } from './scenario-features.module';
export { ScenarioFeaturesService } from './scenario-features.service';
export { ScenariosFeaturesView } from './scenario-features.dto';
export { FeaturesCreated } from './features-created.event';
export { SpecificationProcessingFinishedEvent } from '@marxan-api/modules/scenario-specification/adapters/specification-processing-finished.event';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this event a part of adapters really?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, but boundaries between two modules is artificial a bit, and I need to reflect the state of the specification by the event

@Dyostiq Dyostiq merged commit 5bd7b0e into develop Aug 27, 2021
@Dyostiq Dyostiq deleted the fix/MARXAN-687-keep-only-current-spec-data-for-processing branch August 27, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgajowy kgajowy kgajowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dyostiq @kgajowy