-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(projects): allow projects to be public #488
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/BkXos5Yk2iAmx3bmeD3Wo74jeUAY marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/64xyHpvXSogC5Bet1Nsaq7voAstv |
1d5d594
to
f234d8c
Compare
f234d8c
to
7b587de
Compare
7b587de
to
2deb82f
Compare
2deb82f
to
d09d653
Compare
const dtoInfo = { | ||
authenticatedUser: user, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor, but InfoDTO
already does make very little sense (it's a verbatim copy of an undocumented bit in a legacy codebase), let's not introduce new variants of the name such as dtoInfo
, please 😅
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)